Reviewed-by: Star Zeng <star.z...@intel.com>
Thanks,
Star
-----Original Message-----
From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com]
Sent: Wednesday, March 7, 2018 4:27 AM
To: edk2-devel@lists.01.org
Cc: Marc-André Lureau <marcandre.lur...@redhat.com>; Yao, Jiewen
<jiewen....@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com>; Zeng, Star
<star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>
Subject: [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations
From: Marc-André Lureau <marcandre.lur...@redhat.com>
The ZeroMem() call goes beyond the HashInterfaceHob structure, causing HOB list
corruption. Instead, just clear the HashInterface fields, as I suppose was
originally intended.
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Chao Zhang <chao.b.zh...@intel.com>
Cc: Star Zeng <star.z...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
.../HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
index dbee0f2531bc..361a4f6508a0 100644
--- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
+++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRoute
+++ rPei.c
@@ -424,7 +424,8 @@ HashLibBaseCryptoRouterPeiConstructor (
// This is the second execution of this module, clear the hash interface
// information registered at its first execution.
//
- ZeroMem (&HashInterfaceHob->HashInterface, sizeof (*HashInterfaceHob) -
sizeof (EFI_GUID));
+ ZeroMem (&HashInterfaceHob->HashInterface, sizeof
(HashInterfaceHob->HashInterface));
+ HashInterfaceHob->HashInterfaceCount = 0;
}
//
--
2.16.2.346.g9779355e34
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
