Reviewed-by: Star Zeng <[email protected]> Thanks, Star -----Original Message----- From: Zhang, Chao B Sent: Thursday, March 8, 2018 8:35 AM To: [email protected]; [email protected] Cc: [email protected]; Yao, Jiewen <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Zeng, Star <[email protected]> Subject: RE: [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask
Reviewed-by: Chao Zhang<[email protected]> -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: Wednesday, March 7, 2018 11:58 PM To: [email protected] Cc: [email protected]; Yao, Jiewen <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Marc-André Lureau <[email protected]>; Zhang, Chao B <[email protected]>; Zeng, Star <[email protected]> Subject: [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask From: Marc-André Lureau <[email protected]> Commit 4cc2b63bd829426b05bad0d8952f1855a10d6ed7 fixed an out of bounds ZeroMem() call. However, as Laszlo Ersek pointed out, the intent was to clear all but the Identifier (to revert the effect of RegisterHashInterfaceLib()). For that, it should clear the SupportedHashMask too. Cc: Jiewen Yao <[email protected]> Cc: Chao Zhang <[email protected]> Cc: Star Zeng <[email protected]> Cc: Laszlo Ersek <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau <[email protected]> --- .../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c index 361a4f6508a0..bf6e1336ee76 100644 --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRoute +++ rPei.c @@ -426,6 +426,7 @@ HashLibBaseCryptoRouterPeiConstructor ( // ZeroMem (&HashInterfaceHob->HashInterface, sizeof (HashInterfaceHob->HashInterface)); HashInterfaceHob->HashInterfaceCount = 0; + HashInterfaceHob->SupportedHashMask = 0; } // -- 2.16.2.346.g9779355e34 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
