On 2018-03-12 05:10:34, Laszlo Ersek wrote: > On 03/12/18 09:43, Jordan Justen wrote: > > On 2018-03-11 04:54:51, Ard Biesheuvel wrote: > > >> I am merely saying that it is not always necessary to share your > >> personal journey resulting in the patches at this level of detail, > >> simply because it doesn't scale. > > > > True. > > Message received, loud and clear. :)
Well, I didn't mean for it too be loud and clear. :) I meant to say, at a first glance, it appeared to be overly partitioned. After looking closer it seemed reasonable. I don't think there's a simple answer to this question, but it is probably better to err on the side of being a bit over partitioned. Taking the task of adding a bunch of .h files to .inf files. If they can be easily identified, then it seems reaonable to have a single patch for a package. If it takes more careful analysis, then I guess it's fine to capture that via separate commits. Sorting .c files in package starts to get a little more dicey. What if a mistake is made? It might be nice to be able to bisect commits to find the issue. (Although the build error probably will lead straight to it as well. :) -Jordan > > Originally I was going to suggest that it might be worth making > > 1 patch per package, but after looking over the changes, it seems that > > scope is maybe a bit to large for that. > > > >> In any case, I am happy with this to go in as is, if you prefer. > > > > Also after looking it over, it appears that Laszlo put quite a bit of > > information into each commit message. I agree that it might be sliced > > a little too finely, but I guess after seeing the effort he put into > > it, I prefer Laszlo go ahead and keep the separate commits. > > > > Series Reviewed-by: Jordan Justen <[email protected]> > > Thank you both for putting up with the excessive detail. I'll attempt to > do better next time. > > Laszlo > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
