On 03/26/18 03:26, Ni, Ruiyu wrote: > On 3/24/2018 11:52 AM, Ard Biesheuvel wrote: >> On 23 March 2018 at 21:57, Laszlo Ersek <[email protected]> wrote: >>> According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is >>> supposed >>> to catch an invalid BltOperation, and report it with >>> EFI_INVALID_PARAMETER. >>> >>> Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents >>> this >>> from working in NOOPT and DEBUG builds. >>> >>> Cc: Ard Biesheuvel <[email protected]> >>> Cc: Rocky <[email protected]> >>> Cc: Ruiyu Ni <[email protected]> >>> Reported-by: Rocky <[email protected]> >>> Analyzed-by: Ruiyu Ni <[email protected]> >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=897 >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Laszlo Ersek <[email protected]> >> >> Reviewed-by: Ard Biesheuvel <[email protected]> >> >>> --- >>> >>> Notes: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: qemuvideo_invalid_bltop >>> >>> OvmfPkg/QemuVideoDxe/Gop.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c >>> index b479d24a8763..d51efc2a83d5 100644 >>> --- a/OvmfPkg/QemuVideoDxe/Gop.c >>> +++ b/OvmfPkg/QemuVideoDxe/Gop.c >>> @@ -366,7 +366,7 @@ Returns: >>> >>> default: >>> Status = EFI_INVALID_PARAMETER; >>> - ASSERT (FALSE); >>> + break; >>> } >>> >>> gBS->RestoreTPL (OriginalTPL); >>> -- >>> 2.14.1.3.gb7cf6e02401b >>> > Reviewed-by: Ruiyu Ni <[email protected]> >
Thank you both, commit e1fb441624cd. Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
