Reviewed-by: Chasel Chiu <[email protected]>
-----Original Message-----
From: Zeng, Star
Sent: Wednesday, March 28, 2018 5:31 PM
To: [email protected]
Cc: Zeng, Star <[email protected]>; Chiu, Chasel <[email protected]>; Ni,
Ruiyu <[email protected]>; Gao, Liming <[email protected]>; Yao, Jiewen
<[email protected]>
Subject: [PATCH] MdeModulePkg Variable: Align TPL level for (Smm)EndOfDxe
callback
VariableRuntimeDxe will have OnEndOfDxe() callback function at TPL_NOTIFY level
on EndOfDxe event when DXE variable solution is used.
Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL,
TPL_NOTIFY,
OnEndOfDxe,
NULL,
&gEfiEndOfDxeEventGroupGuid,
&EndOfDxeEvent
);
VariableSmm will have SmmEndOfDxeCallback() callback function at TPL_CALLBACK
level on SmmEndOfDxe event when SMM variable solution is used.
SmmIplGuidedEventNotify() - PiSmmIpl.c TPL_CALLBACK on EndOfDxe
->
SmmEndOfDxeHandler() - PiSmmCore.c install SmmEndOfDxe protocol
->
SmmEndOfDxeCallback() - VariableSmm.c
The TPL level for (Smm)EndOfDxe callback between VariableRuntimeDxe and
VariableSmm is inconsistent, it will make the unified platform code could not
make sure its TPL_NOTIFY EndOfDxe callback function (to use variable
lock/check) executed before (Smm)EndOfDxe callback function in variable driver.
The variable lock/check will start to protect after (Smm)EndOfDxe callback
function in variable driver is executed.
This patch is to algin the TPL level to TPL_CALLBACK for (Smm)EndOfDxe callback
between VariableRuntimeDxe and VariableSmm.
Cc: Chasel Chiu <[email protected]>
Cc: Ruiyu Ni <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Jiewen Yao <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <[email protected]>
---
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
index b2a373cf98aa..6b04f4f7b394 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
@@ -3,7 +3,7 @@
and volatile storage space and install variable architecture protocol.
Copyright (C) 2013, Red Hat, Inc.
-Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> This program
and the accompanying materials are licensed and made available under the terms
and conditions of the BSD License @@ -547,7 +547,7 @@ VariableServiceInitialize
(
//
Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL,
- TPL_NOTIFY,
+ TPL_CALLBACK,
OnEndOfDxe,
NULL,
&gEfiEndOfDxeEventGroupGuid,
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
