On 03/28/18 22:26, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: https_cacert_rhbz_1536624
According to Star's feedback, I modified patch #1 as follows: > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > index 5a9051648004..6caf603b3d30 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > @@ -3842,10 +3842,6 @@ InitNonVolatileVariableStore ( > > mVariableModuleGlobal->MaxVariableSize = PcdGet32 (PcdMaxVariableSize); > mVariableModuleGlobal->MaxAuthVariableSize = ((PcdGet32 > (PcdMaxAuthVariableSize) != 0) ? PcdGet32 (PcdMaxAuthVariableSize) : > mVariableModuleGlobal->MaxVariableSize); > - mVariableModuleGlobal->MaxVolatileVariableSize = ((PcdGet32 > (PcdMaxVolatileVariableSize) != 0) ? > - PcdGet32 > (PcdMaxVolatileVariableSize) : > - > mVariableModuleGlobal->MaxVariableSize > - ); > > // > // Parse non-volatile variable data and get last variable offset. > @@ -4261,6 +4257,10 @@ VariableCommonInitialize ( > } > } > > + mVariableModuleGlobal->MaxVolatileVariableSize = ((PcdGet32 > (PcdMaxVolatileVariableSize) != 0) ? > + PcdGet32 > (PcdMaxVolatileVariableSize) : > + > mVariableModuleGlobal->MaxVariableSize > + ); > // > // Allocate memory for volatile variable store, note that there is a > scratch space to store scratch data. > // and I added the feedback tags like this: > Reviewed-by: Gary Lin <[email protected]> > Tested-by: Gary Lin <[email protected]> > [[email protected]: set MaxVolatileVariableSize where Star suggested] > Reviewed-by: Star Zeng <[email protected]> To the rest of the patches, I applied the feedback tags as usual. Before pushing the set, I retested it with an OVMF HTTPS boot, and I regression-retested it with an ArmVirtQemu disk boot. Pushed as commit range 3d7ebd643431..9c7d0d499296. Thanks everyone! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
