The patches are good to me. Reviewed-by: Yonghong Zhu <[email protected]>
Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Jaben Carsey Sent: Wednesday, April 04, 2018 6:34 AM To: [email protected] Subject: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring move RegEx compile out of functions/loops share RegEx when have identical data Jaben Carsey (5): BaseTools: Autogen - move RegEx compile BaseTools: GenFds - move RegEx compile BaseTools: Add new RegEx pattern to GlobalData BaseTools: AutoGen - use the new shared RegEx BaseTools: remove redundant check BaseTools/Source/Python/AutoGen/AutoGen.py | 22 +++++++++++++------- BaseTools/Source/Python/AutoGen/IdfClassObject.py | 5 +++-- BaseTools/Source/Python/AutoGen/UniClassObject.py | 8 +++---- BaseTools/Source/Python/Common/GlobalData.py | 3 +++ BaseTools/Source/Python/GenFds/FdfParser.py | 5 ++--- 5 files changed, 27 insertions(+), 16 deletions(-) -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
