Reviewed-by: Yonghong Zhu <[email protected]> Best Regards, Zhu Yonghong
-----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Jaben Carsey Sent: Friday, April 06, 2018 7:14 AM To: [email protected] Subject: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity group of changes to make code smaller and reduce overhead. Jaben Carsey (14): BaseTools: remove unused file BaseTools: remove uncalled functions BaseTools: defaultdict(set) allows us to just add to the set BaseTools: sets are faster to check via "in" due to hashing BaseTools: replace a dict with a set BaseTools: remove unused variables BaseTools: change list to set BaseTools: simplify testing for existance and containing data BaseTools: optimize buildoptions loop BaseTools: change another list to set BaseTools: remove unneeded function call BaseTools: change more list to set BaseTools: GenC - move content from both parts of if/else BaseTools: refactor and remove out of date use of .keys() BaseTools/Scripts/SmiHandlerProfileSymbolGen.py | 4 +- BaseTools/Source/Python/AutoGen/AutoGen.py | 101 +++++++------------- BaseTools/Source/Python/AutoGen/BuildEngine.py | 29 ++---- BaseTools/Source/Python/AutoGen/GenC.py | 6 +- BaseTools/Source/Python/AutoGen/GenMake.py | 2 +- BaseTools/Source/Python/Common/Dictionary.py | 76 --------------- BaseTools/Source/Python/Common/TargetTxtClassObject.py | 27 ------ BaseTools/Source/Python/Common/ToolDefClassObject.py | 7 +- BaseTools/Source/Python/GenFds/Fv.py | 2 +- BaseTools/Source/Python/GenFds/Section.py | 5 +- BaseTools/Source/Python/TargetTool/TargetTool.py | 3 +- BaseTools/Source/Python/UPT/PomAdapter/InfPomAlignment.py | 5 +- BaseTools/Source/Python/build/build.py | 4 +- 13 files changed, 59 insertions(+), 212 deletions(-) delete mode 100644 BaseTools/Source/Python/Common/Dictionary.py -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
