Yes, it needs changes corresponding to commit 6281a2ed3bb3ffe57ed54cabd9a31dcf13b415f8.
> -----Original Message----- > From: Leif Lindholm [mailto:[email protected]] > Sent: Thursday, April 19, 2018 3:25 PM > To: Meenakshi Aggarwal <[email protected]> > Cc: [email protected]; [email protected]; Udit Kumar > <[email protected]>; Varun Sethi <[email protected]> > Subject: Re: [PATCH edk2-platforms 17/39] LS1043 : Enable NOR driver for > LS1043aRDB package. > > On Fri, Feb 16, 2018 at 02:20:13PM +0530, Meenakshi wrote: > > From: Meenakshi Aggarwal <[email protected]> > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Meenakshi Aggarwal <[email protected]> > > Will this one require any changes to build (and work correctly) > against current edk2? > > If not: > Reviewed-by: Leif Lindholm <[email protected]> > > / > Leif > > > --- > > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 16 > +++++++++++++++- > > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 9 ++++++++- > > 2 files changed, 23 insertions(+), 2 deletions(-) > > > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > index df4d917..7708e0a 100644 > > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > @@ -41,6 +41,7 @@ > > IfcLib|Silicon/NXP/Library/IfcLib/IfcLib.inf > > BoardLib|Platform/NXP/LS1043aRdbPkg/Library/BoardLib/BoardLib.inf > > FpgaLib|Platform/NXP/LS1043aRdbPkg/Library/FpgaLib/FpgaLib.inf > > + NorFlashLib|Silicon/NXP/Library/NorFlashLib/NorFlashLib.inf > > > > [PcdsFixedAtBuild.common] > > > > @@ -70,6 +71,13 @@ > > gDs1307RtcLibTokenSpaceGuid.PcdI2cSlaveAddress|0x68 > > gDs1307RtcLibTokenSpaceGuid.PcdI2cBusFrequency|100000 > > > > + # > > + # NV Storage PCDs. > > + # > > + gArmTokenSpaceGuid.PcdVFPEnabled|1 > > + gNxpQoriqLsTokenSpaceGuid.PcdFlashDeviceBase64|0x060000000 > > + > gNxpQoriqLsTokenSpaceGuid.PcdFlashReservedRegionBase64|0x60300000 > > + > > > ########################################################## > ###################### > > # > > # Components Section - list of all EDK II Modules needed by this Platform > > @@ -79,9 +87,15 @@ > > # > > # Architectural Protocols > > # > > - > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime > Dxe.inf > > + > > + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf{ > > + <LibraryClasses> > > + NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > > + } > > + > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.in > f > > > > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > > + Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > > > ## > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > index fa6510c..6b5b63f 100644 > > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > @@ -55,6 +55,7 @@ > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > FV = FVMAIN_COMPACT > > > > !include ../FVRules.fdf.inc > > +!include VarStore.fdf.inc > > > ########################################################## > ###################### > > # > > # FV Section > > @@ -103,7 +104,8 @@ READ_LOCK_STATUS = TRUE > > INF > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > > INF > EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter > .inf > > - INF > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime > Dxe.inf > > + INF > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > > + INF > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.in > f > > INF > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntime > Dxe.inf > > > > INF Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > > @@ -123,6 +125,11 @@ READ_LOCK_STATUS = TRUE > > INF EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOutSerial.inf > > > > # > > + # NOR Driver > > + # > > + INF Silicon/NXP/Drivers/NorFlashDxe/NorFlashDxe.inf > > + > > + # > > # Network modules > > # > > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > > -- > > 1.9.1 > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
