On Mon, Apr 23, 2018 at 05:07:02PM +0000, Girish Pathak wrote: > Hi Leif, > > > -----Original Message----- > > From: Leif Lindholm <[email protected]> > > Sent: 23 April 2018 18:03 > > To: Girish Pathak <[email protected]> > > Cc: [email protected]; [email protected]; Matteo Carlini > > <[email protected]>; Stephanie Hughes-Fitt <Stephanie.Hughes- > > [email protected]>; nd <[email protected]>; Arvind Chauhan > > <[email protected]>; Daniil Egranov <[email protected]>; > > Thomas Abraham <[email protected]> > > Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove > > unused PcdPL111LcdMaxMode from HDLCD inf > > > > On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote: > > > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > > > Presence of this PCD in HDLCD is probably due to copy/paste code from > > > PL111 Lcd platform library. This change removes it from the > > > HdLcdArmVExpressLib.inf file. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Urgh - push failed on the above. > > Can you confirm it should be version 1.1? > Oops.. Sorry my fault. It should be 1.1
Well, it made it past everyone except for my pre-push hook script... Thanks - series: Reviewed-by: Leif Lindholm <[email protected]> Pushed as 0b5af57f00..b581a4934d. Regards, Leif > Thanks, > Girish > > / > > Leif > > > > > Signed-off-by: Girish Pathak <[email protected]> > > > Signed-off-by: Evan Lloyd <[email protected]> > > > Reviewed-by: Ard Biesheuvel <[email protected]> > > > --- > > > > > > > > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpr > > essL > > > ib.inf | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git > > > > > a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > pres > > > sLib.inf > > > > > b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > pres > > > sLib.inf index > > > > > bedbaea3a296bea5184564c582659381733d08a9..34db24d4ee6162b0e963d50 > > 0a8ed > > > 1097bd8a5ceb 100644 > > > --- > > > > > a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > pres > > > sLib.inf > > > +++ > > b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > > +++ pressLib.inf > > > @@ -40,5 +40,4 @@ [Protocols] > > > gEfiEdidActiveProtocolGuid # Produced > > > > > > [Pcd] > > > - gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > > > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > > > -- > > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
