Reviewed-by: Yonghong Zhu <[email protected]> Best Regards, Zhu Yonghong
-----Original Message----- From: Carsey, Jaben Sent: Friday, April 20, 2018 11:52 PM To: [email protected] Cc: Gao, Liming <[email protected]>; Zhu, Yonghong <[email protected]> Subject: [PATCH v1 25/27] BaseTools: AutoGen - use defaultdict to auto initialize Cc: Liming Gao <[email protected]> Cc: Yonghong Zhu <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <[email protected]> --- BaseTools/Source/Python/AutoGen/GenVar.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/GenVar.py b/BaseTools/Source/Python/AutoGen/GenVar.py index 37c168a84b43..99c6ed640c00 100644 --- a/BaseTools/Source/Python/AutoGen/GenVar.py +++ b/BaseTools/Source/Python/AutoGen/GenVar.py @@ -128,7 +128,7 @@ class VariableMgr(object): return var_value def process_variable_data(self): - var_data = dict() + var_data = collections.defaultdict(collections.OrderedDict) indexedvarinfo = collections.OrderedDict() for item in self.VarInfo: @@ -155,8 +155,6 @@ class VariableMgr(object): for item in default_data_buffer: default_data_array += unpack("B",item) - if (DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT) not in var_data: - var_data[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)] = collections.OrderedDict() var_data[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)][index] = (default_data_buffer,sku_var_info[(DataType.TAB_DEFAULT,DataType.TAB_DEFAULT_STORES_DEFAULT)]) for (skuid,defaultstoragename) in indexedvarinfo.get(index): @@ -177,8 +175,6 @@ class VariableMgr(object): data_delta = self.calculate_delta(default_data_array, others_data_array) - if (skuid,defaultstoragename) not in var_data: - var_data[(skuid,defaultstoragename)] = collections.OrderedDict() var_data[(skuid,defaultstoragename)][index] = (data_delta,sku_var_info[(skuid,defaultstoragename)]) return var_data -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
