On Fri, May 04, 2018 at 11:29:33AM +0800, Haojian Zhuang wrote: > On 2 May 2018 at 23:14, Leif Lindholm <[email protected]> wrote: > >> + { 0xe8a0b000, 0, 8 }, // GPIO0 > > > > It would not improve readability to request all of these live-coded > > values to be replaced by #defines, but barring that, could you add a > > comment header before the definition?: > > > > // { base address, gpio index, gpio count } > > > > OK > >> + { 0xe8a0c000, 8, 8 }, // GPIO1 > >> + { 0xe8a0d000, 16, 8 }, // GPIO2 > >> + { 0xe8a0e000, 24, 8 }, // GPIO3 > >> + { 0xe8a0f000, 32, 8 }, // GPIO4 > >> + { 0xe8a10000, 40, 8 }, // GPIO5 > >> + { 0xe8a11000, 48, 8 }, // GPIO6 > >> + { 0xe8a12000, 56, 8 }, // GPIO7 > >> + { 0xe8a13000, 64, 8 }, // GPIO8 > >> + { 0xe8a14000, 72, 8 }, // GPIO9 > >> + { 0xe8a15000, 80, 8 }, // GPIO10 > >> + { 0xe8a16000, 88, 8 }, // GPIO11 > >> + { 0xe8a17000, 96, 8 }, // GPIO12 > >> + { 0xe8a18000, 104, 8 }, // GPIO13 > >> + { 0xe8a19000, 112, 8 }, // GPIO14 > >> + { 0xe8a1a000, 120, 8 }, // GPIO15 > >> + { 0xe8a1b000, 128, 8 }, // GPIO16 > >> + { 0xe8a1c000, 136, 8 }, // GPIO17 > >> + { 0xff3b4000, 144, 8 }, // GPIO18 > >> + { 0xff3b5000, 152, 8 }, // GPIO19 > > > > I notice that these: > >> + { 0xe8a1f000, 160, 8 }, // GPIO20 > >> + { 0xe8a20000, 168, 8 }, // GPIO21 > > are out of order, from their base address. > > Are the names GPIO20/GPIO21 defined in the TRM? > > > > Yes, it's mentioned in the TRM.
Yeah, I figured as much, but was hoping for something else :) > (https://github.com/96boards/documentation/blob/master/consumer/hikey960/hardware-docs/HiKey960_SoC_Reference_Manual.pdf) Thanks for the link - that will be useful! / Leif _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
