Hi Jaben.
On 05/04/18 22:25, Jaben Carsey wrote:
> Commit eece4292acc80 changed a variable name, which was tied directly to
> a config file entry. This seperates the internal variable names from
> the config file entries by having the internal dict accessed through a
> translation of key words.
>
> added a test when this is run straight from command line.
>
> Cc: Liming Gao <liming....@intel.com>
> Cc: Yonghong Zhu <yonghong....@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
> ---
> BaseTools/Source/Python/Ecc/Configuration.py | 122 +++++++++++++++++++-
> 1 file changed, 119 insertions(+), 3 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Ecc/Configuration.py
> b/BaseTools/Source/Python/Ecc/Configuration.py
> index b5b583be8c4a..d305182a2666 100644
> --- a/BaseTools/Source/Python/Ecc/Configuration.py
> +++ b/BaseTools/Source/Python/Ecc/Configuration.py
> @@ -1,7 +1,7 @@
> ## @file
> # This file is used to define class Configuration
> #
> -# Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD
> License
> # which accompanies this distribution. The full text of the license may be
> found at
> @@ -20,6 +20,109 @@ from Common.DataType import *
> from Common.String import *
> from Common.LongFilePathSupport import OpenLongFilePath as open
>
> +_ConfigFileToInternalTranslation = {
> + # not same
> + "ModifierList":"ModifierSet",
> +
Git complains that the above line contains trailing whitespace.
But, that can be removed when you push this patch.
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
I've also run the Ecc tool (I didn't try to execute the self-test), and
now it seems to work fine.
Tested-by: Laszlo Ersek <ler...@redhat.com>
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
