It is a good change. :) Only one minor comment. How about using EFI_REQUEST_UNLOAD_IMAGE instead?
/// /// If this value is returned by an EFI image, then the image should be unloaded. /// #define EFI_REQUEST_UNLOAD_IMAGE DXE_ERROR (1) Thanks, Star -----Original Message----- From: Marvin Häuser [mailto:[email protected]] Sent: Saturday, May 5, 2018 10:26 PM To: [email protected] Cc: Zeng, Star <[email protected]>; Dong, Eric <[email protected]>; Ni, Ruiyu <[email protected]> Subject: [PATCH] MdeModulePkg/AcpiPlatformDxe: Unload after execution. AcpiPlatformDxe solely performs one-time tasks and does not expose any services or create any events. Hence it can safely be unloaded after the Entry Point execution by returning an error code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser <[email protected]> --- MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatform.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatform.c b/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatform.c index 44bdd94fa8db..8772961bfd31 100644 --- a/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatform.c +++ b/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatform.c @@ -1,7 +1,7 @@ /** @file Sample ACPI Platform Driver - Copyright (c) 2008 - 2011, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2008 - 2018, Intel Corporation. All rights + reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -255,6 +255,9 @@ AcpiPlatformEntryPoint ( } } - return EFI_SUCCESS; + // + // Return an error code so that the driver is unloaded. + // + return EFI_ALREADY_STARTED; } -- 2.17.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
