Reviewed-by: Liming Gao <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Marvin > H?user > Sent: Saturday, May 5, 2018 10:24 PM > To: [email protected] > Cc: Kinney, Michael D <[email protected]>; Gao, Liming > <[email protected]> > Subject: [edk2] [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where > necessary. > > The functions AddUnicodeString() and AddUnicodeString2() might return > a new value into their parameter UnicodeStringTable, hence add the > appropiate 'OUT' decorator. > > V2: Update FrameworkUefiLib as well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser <[email protected]> > --- > MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++--------- > MdePkg/Include/Library/UefiLib.h | 18 +++++++++--------- > 2 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/MdePkg/Library/UefiLib/UefiLib.c > b/MdePkg/Library/UefiLib/UefiLib.c > index f1a3f1c7af05..ba449a1c34ce 100644 > --- a/MdePkg/Library/UefiLib/UefiLib.c > +++ b/MdePkg/Library/UefiLib/UefiLib.c > @@ -888,10 +888,10 @@ LookupUnicodeString2 ( > EFI_STATUS > EFIAPI > AddUnicodeString ( > - IN CONST CHAR8 *Language, > - IN CONST CHAR8 *SupportedLanguages, > - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > - IN CONST CHAR16 *UnicodeString > + IN CONST CHAR8 *Language, > + IN CONST CHAR8 *SupportedLanguages, > + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > + IN CONST CHAR16 *UnicodeString > ) > { > UINTN NumberOfEntries; > @@ -1065,11 +1065,11 @@ AddUnicodeString ( > EFI_STATUS > EFIAPI > AddUnicodeString2 ( > - IN CONST CHAR8 *Language, > - IN CONST CHAR8 *SupportedLanguages, > - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > - IN CONST CHAR16 *UnicodeString, > - IN BOOLEAN Iso639Language > + IN CONST CHAR8 *Language, > + IN CONST CHAR8 *SupportedLanguages, > + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > + IN CONST CHAR16 *UnicodeString, > + IN BOOLEAN Iso639Language > ) > { > UINTN NumberOfEntries; > diff --git a/MdePkg/Include/Library/UefiLib.h > b/MdePkg/Include/Library/UefiLib.h > index 54bc2cc5a334..256498e3fd8d 100644 > --- a/MdePkg/Include/Library/UefiLib.h > +++ b/MdePkg/Include/Library/UefiLib.h > @@ -587,10 +587,10 @@ LookupUnicodeString2 ( > EFI_STATUS > EFIAPI > AddUnicodeString ( > - IN CONST CHAR8 *Language, > - IN CONST CHAR8 *SupportedLanguages, > - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > - IN CONST CHAR16 *UnicodeString > + IN CONST CHAR8 *Language, > + IN CONST CHAR8 *SupportedLanguages, > + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > + IN CONST CHAR16 *UnicodeString > ); > > /** > @@ -638,11 +638,11 @@ AddUnicodeString ( > EFI_STATUS > EFIAPI > AddUnicodeString2 ( > - IN CONST CHAR8 *Language, > - IN CONST CHAR8 *SupportedLanguages, > - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > - IN CONST CHAR16 *UnicodeString, > - IN BOOLEAN Iso639Language > + IN CONST CHAR8 *Language, > + IN CONST CHAR8 *SupportedLanguages, > + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, > + IN CONST CHAR16 *UnicodeString, > + IN BOOLEAN Iso639Language > ); > > /** > -- > 2.17.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
