Hi Jiewen, I do the basic functionality test base on the opal UI. Also I request the QA to do the full regression test and no issue found.
Also will include unit test info in later patches. Thanks for your comments. Thanks, Eric -----Original Message----- From: Yao, Jiewen Sent: Tuesday, May 8, 2018 1:42 PM To: Dong, Eric <[email protected]>; [email protected]; Wu, Hao A <[email protected]> Subject: RE: [edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver. Hi Eric Would you please add more detail on what unit test has been done for this patch? Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Eric Dong > Sent: Wednesday, May 2, 2018 8:17 PM > To: [email protected]; Wu, Hao A <[email protected]> > Subject: [edk2] [Patch 0/3] Enable Pyrite 2.0 for opal driver. > > Eanble the pyrite 2.0 devices for opal driver. > > Eric Dong (3): > MdePkg: Add Feature definitions add in pyrite 2.0 spec. > SecurityPkg/TcgStorageOpalLib: Add supports for pyrite 2.0 spec. > SecurityPkg/OpalPassword: Add support for pyrite 2.0 devices. > > MdePkg/Include/IndustryStandard/TcgStorageCore.h | 2 + > MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 54 +++ > SecurityPkg/Include/Library/TcgStorageOpalLib.h | 41 ++ > .../Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 426 > ++++++++++++++++++--- > .../TcgStorageOpalLib/TcgStorageOpalLib.inf | 1 + > .../TcgStorageOpalLib/TcgStorageOpalLibInternal.h | 98 +++++ > .../Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 214 ++++++++++- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 60 ++- > SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.h | 9 + > SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 84 ++++ > .../Tcg/Opal/OpalPassword/OpalPasswordPei.c | 1 + > 11 files changed, 934 insertions(+), 56 deletions(-) create mode > 100644 > SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLibInternal.h > > -- > 2.15.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
