On Tue, May 08, 2018 at 11:50:46AM +0000, Bi, Dandan wrote: > Yes. We have submitted patch to fix it. Sorry for the inconvenience. > Awesome! Thanks for the quick response :)
Gary Lin > Thanks, > Dandan > > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Gary > Lin > Sent: Tuesday, May 8, 2018 5:46 PM > To: Bi, Dandan <[email protected]> > Cc: [email protected]; Dong, Eric <[email protected]>; Gao, Liming > <[email protected]> > Subject: Re: [edk2] [patch 1/2] BaseTools/VfrCompile:Fix memory leak issues > > On Tue, Apr 10, 2018 at 03:54:46PM +0800, Dandan Bi wrote: > > Cc: Eric Dong <[email protected]> > > Cc: Liming Gao <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Dandan Bi <[email protected]> > > --- > > BaseTools/Source/C/VfrCompile/VfrSyntax.g | 32 > > ++++++++++++++++++++++++++++++- > > 1 file changed, 31 insertions(+), 1 deletion(-) > > > > diff --git a/BaseTools/Source/C/VfrCompile/VfrSyntax.g > > b/BaseTools/Source/C/VfrCompile/VfrSyntax.g > > index d48072a8adf..4b0a43606ea 100644 > > --- a/BaseTools/Source/C/VfrCompile/VfrSyntax.g > > +++ b/BaseTools/Source/C/VfrCompile/VfrSyntax.g > Hi Dandan, > > I encountered a build error with our build service: > > [ 197s] "VfrCompile" -l -n --string-db > /home/abuild/rpmbuild/BUILD/ovmf-2018+git1525681922.053cd183c9f2/Build/OvmfX64/DEBUG_GCC5/X64/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib/OUTPUT/BootMaintenanceManagerUiLibStrDefs.hpk > --output-directory > /home/abuild/rpmbuild/BUILD/ovmf-2018+git1525681922.053cd183c9f2/Build/OvmfX64/DEBUG_GCC5/X64/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib/DEBUG/. > > /home/abuild/rpmbuild/BUILD/ovmf-2018+git1525681922.053cd183c9f2/Build/OvmfX64/DEBUG_GCC5/X64/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib/OUTPUT/BootMaintenanceManager.i > [ 197s] *** Error in > `/home/abuild/rpmbuild/BUILD/ovmf-2018+git1525681922.053cd183c9f2/BaseTools/Source/C/bin/VfrCompile': > free(): invalid pointer: 0xbabababababababa *** > > If I reverted the following change, the package can be built again. > > > @@ -5055,11 +5082,14 @@ EfiVfrParser::_SAVE_OPHDR_COND ( VOID > > EfiVfrParser::_CLEAR_SAVED_OPHDR ( > > VOID > > ) > > { > > - mCIfrOpHdr[mCIfrOpHdrIndex] = NULL; > > + if (mCIfrOpHdr[mCIfrOpHdrIndex] != NULL) { > > + delete mCIfrOpHdr[mCIfrOpHdrIndex]; > > + mCIfrOpHdr[mCIfrOpHdrIndex] = NULL; > > + } > > mCIfrOpHdrLineNo[mCIfrOpHdrIndex] = 0; } > > > > BOOLEAN > > EfiVfrParser::_SET_SAVED_OPHDR_SCOPE ( > > I have no clue now and it happened all the time. > > Would you mind to check the code? > > Thanks, > > Gary Lin > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
