On 05/14/18 12:28, Ard Biesheuvel wrote: > On 13 May 2018 at 00:55, Laszlo Ersek <[email protected]> wrote: >> If both ConIn and ConOut exist, but ConIn references none of the PS/2 >> keyboard, the USB wild-card keyboard, and any serial ports, then >> PlatformInitializeConsole() currently allows the boot to proceed without >> any input devices at all. This makes for a bad user experience -- the >> firmware menu could only be entered through OsIndications, set by a guest >> OS. >> >> Do what ArmVirtQemu does already, namely connect the consoles, and add >> them to ConIn / ConOut / ErrOut, unconditionally. (The underlying >> EfiBootManagerUpdateConsoleVariable() function checks for duplicates.) >> >> The issue used to be masked by the EfiBootManagerConnectAll() call that >> got conditionalized in commit 245c643cc8b7. >> >> This patch is best viewed with "git show -b -W". >> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: Jordan Justen <[email protected]> >> Fixes: 245c643cc8b73240c3b88cb55b2911b285a8c10d >> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1577546 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek <[email protected]> > > Reviewed-by: Ard Biesheuvel <[email protected]>
Thank you (and welcome back :) ), commit f803c03cc2e0. Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
