Hey Jaben, I'm used to keeping the copyright date updated and because both the specification where the definition originates from and the present header are published by Intel, this effectively is all Intel IP. Was this an incorrect change nevertheless? I'm not an expert in OSS contribution law.
Thanks, Marvin > -----Original Message----- > From: Carsey, Jaben <[email protected]> > Sent: Tuesday, May 15, 2018 11:26 PM > To: Marvin Häuser <[email protected]> > Subject: RE: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. > > Marvin, > > Non-technical question here, but why do you update intel copyright from a > non-intel email address. This seems odd to me... > > Thanks > -Jaben > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Marvin Häuser > > Sent: Tuesday, May 15, 2018 12:35 PM > > To: [email protected] > > Cc: Kinney, Michael D <[email protected]>; Gao, Liming > > <[email protected]> > > Subject: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID > definition. > > > > This patch adds the HPET Event Timer Block ID definition that can be > > found in the IA-PC HPET Specification, section 3.2.4. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marvin Haeuser <[email protected]> > > --- > > MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h | 18 > > +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git > > a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > index 0d83cd5335de..926445233944 100644 > > --- a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > +++ b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > @@ -2,7 +2,7 @@ > > ACPI high precision event timer table definition, at www.intel.com > > Specification name is IA-PC HPET (High Precision Event Timers) > > Specification. > > > > - Copyright (c) 2007 - 2008, Intel Corporation. All rights > > reserved.<BR> > > + Copyright (c) 2007 - 2018, Intel Corporation. All rights > > + reserved.<BR> > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of > > the BSD License > > which accompanies this distribution. The full text of the license > > may be found at @@ -22,6 +22,22 @@ // #pragma pack(1) > > > > +/// > > +/// HPET Event Timer Block ID described in IA-PC HPET Specification, 3.2.4. > > +/// > > +typedef union { > > + struct { > > + UINT32 Revision : 8; > > + UINT32 NumberOfTimers : 5; > > + UINT32 CounterSize : 1; > > + UINT32 Reserved : 1; > > + UINT32 LegacyRoute : 1; > > + UINT32 VendorId : 16; > > + } Bits; > > + UINT32 Uint32; > > +} EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_BLOCK_ID; > > + > > + > > /// > > /// High Precision Event Timer Table header definition. > > /// > > -- > > 2.17.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
