Still looks good to me. Ray?
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Marvin Häuser > Sent: Thursday, May 17, 2018 5:43 AM > To: [email protected] > Cc: Carsey, Jaben <[email protected]>; Ni, Ruiyu <[email protected]> > Subject: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > unspecified local Timezone. > Importance: High > > EFI_RUNTIME_SERVICES.GetTime() might return an unspecified Timezone, > such as when SetTime() has not been called after the PC-AT CMOS RTC > was cut off power. Consider this case by not attempting Timezone > translations for when it is invalid. > > V2: > - Do not change the copyright date as requested. > - Added R-bs from V1 as no functional changes have been made. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser <[email protected]> > Reviewed-by: Jaben Carsey <[email protected]> > Reviewed-by: Ruiyu Ni <[email protected]> > --- > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > index 7d2e15f5206b..e502685a1dbb 100644 > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > @@ -506,7 +506,7 @@ PrintLsOutput( > // Change the file time to local time. > // > Status = gRT->GetTime(&LocalTime, NULL); > - if (!EFI_ERROR (Status)) { > + if (!EFI_ERROR (Status) && (LocalTime.TimeZone != > EFI_UNSPECIFIED_TIMEZONE)) { > if ((Node->Info->CreateTime.TimeZone != > EFI_UNSPECIFIED_TIMEZONE) && > (Node->Info->CreateTime.Month >= 1 && Node->Info- > >CreateTime.Month <= 12)) { > // > -- > 2.17.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
