On 05/17/18 16:43, Marc-André Lureau wrote: > On Wed, May 16, 2018 at 11:29 AM, Laszlo Ersek <ler...@redhat.com> wrote:
>> - the "xfuncname"-related settings, so that git diff hunk headers @@ >> are useful for DSC and INF files too, >> > > This is already in my .git/config, I hope it takes it by default in > format-patch? You also need to classify files appropriately so that the xfuncname setting apply to them: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09 >> Not much of a review, I know; this is all I can offer right now. If you >> have the time to respin just with these superficial changes, that might >> make my life easier. If you prefer to delay them, that's 100% fine too. >> > > I am going to resend with the style fixes. I managed to review your v1 in full earlier today, so I'd prefer to review your v3, with my more in-depth comments addressed as well. Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
