On 05/24/18 10:16, Ard Biesheuvel wrote: > On 23 May 2018 at 22:21, Laszlo Ersek <[email protected]> wrote: >> Replace the manual capability list parsing in OvmfPkg/Virtio10Dxe with >> PciCapLib and PciCapPciIoLib API calls. >> >> The VIRTIO_PCI_CAP_LINK structure type is now superfluous. (Well, it >> always has been; we should have used EFI_PCI_CAPABILITY_HDR.) >> >> Also, EFI_PCI_CAPABILITY_VENDOR_HDR is now included at the front of >> VIRTIO_PCI_CAP. No driver other than Virtio10Dxe relies on VIRTIO_PCI_CAP. >> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: Jordan Justen <[email protected]> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek <[email protected]> > > Reviewed-by: Ard Biesheuvel <[email protected]>
Thanks for the super quick review! Can you please clarify your review of 2/7? You agreed with the commit msg (thanks!) but didn't comment on the code in either direction. Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
