On 05/24/18 22:36, Jordan Justen wrote: > Reviewed-by: Jordan Justen <[email protected]> > > Pushed as 7dc7c7435e. > > On 2018-05-17 05:43:30, Marvin Häuser wrote: >> Currently, SmbiosLib declares the PcdLib library class. Update the >> declaration to declare SmbiosLib. >> >> V2: >> - Do not change the copyright date as requested. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marvin Haeuser <[email protected]> >> --- >> EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> index adcd7ef08e20..36d5c350f51a 100644 >> --- a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> +++ b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> @@ -20,7 +20,7 @@ [Defines] >> FILE_GUID = 881863A2-09FD-3E44-8D62-7AE038D03747 >> MODULE_TYPE = DXE_DRIVER >> VERSION_STRING = 1.0 >> - LIBRARY_CLASS = PcdLib|DXE_CORE DXE_DRIVER >> DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION >> UEFI_DRIVER >> + LIBRARY_CLASS = SmbiosLib|DXE_CORE DXE_DRIVER >> DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION >> UEFI_DRIVER >> >> CONSTRUCTOR = SmbiosLibConstructor
(Just because I pondered the question a few days ago, independently, I'll voice it here:) Should BaseTools catch this? "EmulatorPkg/EmulatorPkg.dsc" contains the following library resolution: SmbiosLib|EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf I think it should be possible to flag that the class of the lib instance doesn't match the lib class that the platform DSC is resolving. (Or is Marvin's patch the result of such an error message already?) Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
