On 1 June 2018 at 17:13, Yao, Jiewen <[email protected]> wrote: > Got it. Thanks. > > Reviewed-by: [email protected] >
Thanks all Pushed as c4061d18ef53 > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:[email protected]] >> Sent: Friday, June 1, 2018 8:11 AM >> To: Yao, Jiewen <[email protected]> >> Cc: Zeng, Star <[email protected]>; [email protected]; >> [email protected] >> Subject: Re: [edk2] [PATCH] SignedCapsulePkg: add >> PcdLowestSupportedFirmwareVersion >> >> On 1 June 2018 at 17:09, Yao, Jiewen <[email protected]> wrote: >> > I am about to agree. >> > >> > Would you please share a real example on how this PCD is used in some open >> source platforms? >> > >> >> Please refer to this patch >> https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html >> >> >> Thanks, >> Ard. >> >> >> -----Original Message----- >> >> From: Ard Biesheuvel [mailto:[email protected]] >> >> Sent: Friday, June 1, 2018 3:06 AM >> >> To: Zeng, Star <[email protected]>; Yao, Jiewen <[email protected]> >> >> Cc: [email protected]; [email protected] >> >> Subject: Re: [edk2] [PATCH] SignedCapsulePkg: add >> >> PcdLowestSupportedFirmwareVersion >> >> >> >> On 31 May 2018 at 11:12, Zeng, Star <[email protected]> wrote: >> >> > It could be reused by platform SystemFirmwareDescriptor, for example. >> >> > >> >> >> Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwa >> >> reDescriptor.inf >> >> > >> >> >> QuarkPlatformPkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwa >> >> reDescriptor.inf >> >> > >> >> > So, I agree this patch, Reviewed-by: Star Zeng <[email protected]>. >> >> > >> >> > Please also get Jiewen's RB for the patch. >> >> > >> >> >> >> @Jiewen, any comments? >> >> >> >> Thanks, >> >> Ard. >> >> >> >> >> >> > -----Original Message----- >> >> > From: edk2-devel [mailto:[email protected]] On Behalf Of >> Ard >> >> Biesheuvel >> >> > Sent: Thursday, May 31, 2018 5:02 PM >> >> > To: [email protected] >> >> > Cc: Yao, Jiewen <[email protected]>; Zeng, Star >> <[email protected]>; >> >> [email protected]; Ard Biesheuvel <[email protected]> >> >> > Subject: [edk2] [PATCH] SignedCapsulePkg: add >> >> PcdLowestSupportedFirmwareVersion >> >> > >> >> > Add a PCD that holds the lowest supported version number, so that we can >> >> allow the platform to configure this at build time. >> >> > >> >> > Cc: Jiewen Yao <[email protected]> >> >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> >> > Signed-off-by: Ard Biesheuvel <[email protected]> >> >> > --- >> >> > As discussed a while ago: >> >> > https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html >> >> > >> >> > SignedCapsulePkg/SignedCapsulePkg.dec | 4 ++++ >> >> > 1 file changed, 4 insertions(+) >> >> > >> >> > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec >> >> b/SignedCapsulePkg/SignedCapsulePkg.dec >> >> > index b27e87409b19..f06e07656de9 100644 >> >> > --- a/SignedCapsulePkg/SignedCapsulePkg.dec >> >> > +++ b/SignedCapsulePkg/SignedCapsulePkg.dec >> >> > @@ -52,6 +52,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> >> PcdsDynamic, PcdsDynamicEx] >> >> > # @Prompt GUID of the FFS which contains the Pkcs7TestPublicKeyFile. >> >> > >> >> >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0xb >> >> a, 0xf5, 0x93, 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0, >> 0xf7, >> >> 0xe0, 0xb8}|VOID*|0xA0010002 >> >> > >> >> > + ## This is the lowest supported version number that can be upgraded >> >> > to, >> as >> >> exposed via the System Firmware descriptor. >> >> > + # @Prompt Lowest support version number that can be upgraded to via >> >> > + capsule update >> >> > + >> >> > + >> >> >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|0 >> >> > + x1|UINT32|0xA0010003 >> >> > + >> >> > [PcdsDynamicEx] >> >> > ## This dynamic PCD holds the EDKII system firmware image descriptor. >> >> > # This information can be used for version check in EDKII system FMP >> >> capsule. >> >> > -- >> >> > 2.17.0 >> >> > >> >> > _______________________________________________ >> >> > edk2-devel mailing list >> >> > [email protected] >> >> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
