Thanks Ard, I accept all of your comments, I will take care in v2 Regards Udit
> -----Original Message----- > From: Ard Biesheuvel [mailto:[email protected]] > Sent: Tuesday, June 5, 2018 5:55 PM > To: Udit Kumar <[email protected]> > Cc: [email protected]; Leif Lindholm <[email protected]> > Subject: Re: [edk2][PATCH 2/2] ArmPlatformPkg: Include ArmPlatformClock Lib > > On 5 June 2018 at 01:35, Udit Kumar <[email protected]> wrote: > > This patch includes, ArmPlatformClock in PL011 lib. > > > > In case of NULL implemenation of Clock Lib, Pcd value will be used for > > PL011 frequency. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Udit Kumar <[email protected]> > > --- > > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c | 7 > > +++++-- > > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf | 1 > > + > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git > > a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c > > b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c > > index 6aa8063..40fa50a 100644 > > --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c > > +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c > > @@ -17,11 +17,14 @@ > > > > #include <Base.h> > > > > +#include <Library/ArmPlatformClockLib.h> > > #include <Library/IoLib.h> > > #include <Library/PcdLib.h> > > #include <Library/PL011UartLib.h> > > #include <Library/SerialPortLib.h> > > > > + > > + > > Spurious whitespace changes > > > /** Initialise the serial device hardware with default settings. > > > > @retval RETURN_SUCCESS The serial device was initialised. > > @@ -48,7 +51,7 @@ SerialPortInitialize ( > > > > return PL011UartInitializePort ( > > (UINTN)FixedPcdGet64 (PcdSerialRegisterBase), > > - FixedPcdGet32 (PL011UartClkInHz), > > + ArmPlatformGetPL011ClockFreq() ? > > + ArmPlatformGetPL011ClockFreq() : FixedPcdGet32 (PL011UartClkInHz), > > Get rid of this conditional please > > > &BaudRate, > > &ReceiveFifoDepth, > > &Parity, > > @@ -156,7 +159,7 @@ SerialPortSetAttributes ( { > > return PL011UartInitializePort ( > > (UINTN)FixedPcdGet64 (PcdSerialRegisterBase), > > - FixedPcdGet32 (PL011UartClkInHz), > > + ArmPlatformGetPL011ClockFreq() ? > > + ArmPlatformGetPL011ClockFreq() : FixedPcdGet32 (PL011UartClkInHz), > > BaudRate, > > ReceiveFifoDepth, > > Parity, > > diff --git > > a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > > b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > > index 3683e06..9820811 100644 > > --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > > +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > > @@ -26,6 +26,7 @@ > > PL011SerialPortLib.c > > > > [LibraryClasses] > > + ArmPlatformClockLib > > PL011UartLib > > PcdLib > > > > -- > > 1.9.1 > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
