Hi Ard, 2018-06-11 14:01 GMT+02:00 Ard Biesheuvel <ard.biesheu...@linaro.org>: > On 11 June 2018 at 13:49, Marcin Wojtas <m...@semihalf.com> wrote: >> Hi Ard, >> >> 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel <ard.biesheu...@linaro.org>: >>> Marcin, >>> >>> I am a bit reluctant to review another huge set of Armada patches >>> while we are still waiting for MacchiatoBin support to land. The only >>> hardware i have access to is MacchiatoBin, and it has been well over a >>> year now that MacchiatoBin support has been between 'under >>> construction' and 'about to land any day now'. >>> >>> The patches in this series actually carry traces of McBin support, >>> which suggests to me that they were taken from an internal tree that >>> does support MacchiatoBin, but it has been removed. What is that >>> about? >> >> MacchiatoBin addition is on top of those patches in the branch I >> prepared solely for upstream. Anyway, I understand your point and >> let's skip this big patchset for now. I will submit support for other >> boards, once it's accepted, let's return to this one. >> > > > Patch 5/25: > > """ > From: jinghua <jing...@marvell.com> > > This patch enables compilation of MvBoardDescDxe driver for > Armada70x0-DB, Armada80x0-DB and Armada80x0McBin. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: jinghua <jing...@marvell.com> > Reviewed-by: Kostya Porotchkin <kos...@marvell.com> > """ > > So this patch clearly contained MacchiatoBin support at some point, > but you removed it before upstreaming the patch. That really makes me > sad.
Yes, I inverted the order of the patches when cleaning the branch. I wanted to add the whole new boards support in a minimal possible way, but that clearly wasn't best idea. Nvm, I'll submit new board now. > > BTW can you please drop the @marvell.com Reviewed-by tags, and add > your own Signed-off-by to patches that you did not author yourself? Sure will do. Thanks, Marcin _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
