Reviewed-by: Liming Gao <[email protected]>
>-----Original Message----- >From: edk2-devel [mailto:[email protected]] On Behalf Of Hao >Wu >Sent: Tuesday, June 05, 2018 11:20 AM >To: [email protected] >Cc: Wu, Hao A <[email protected]>; Kinney, Michael D ><[email protected]>; Younas Khan ><[email protected]>; Yao, Jiewen <[email protected]>; >Gao, Liming <[email protected]> >Subject: [edk2] [RFC PATCH v1 0/2] Update and refine the IPMI header files > >This series will: >a. Update the IPMI header files with the spec Intelligent Platform > Management Interface Specification Second Generation v2.0 Document > Revision 1.1 (October 1, 2013). >b. Refine those header files to use 'union' types for bitmap fields within > structure definitions, so that both bit-level and byte/word-level > accesses are provided. > >The series is also available at: >https://github.com/hwu25/edk2/tree/ipmi_header_update > > >Please note that this series makes some incompatible changes: > >a. For structure definition IPMI_EMP_DESTINATION_COM_SETTING: >Removes fields 'SaveSetting', 'SetComPort' and 'Reserved3' according to >IPMI v2.0 spec Table 25-4. > >b. For structure definition >IPMI_SET_SERIAL_MODEM_MUX_COMMAND_RESPONSE: >Add missing field 'CompletionCode' according to IPMI v2.0 spec Table 25-5. > >c. For structure definition IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_5: >Update data 1, 4 and 5 according to IPMI v2.0 spec Table 28-14. > >d. Add byte-word-level access for structures with bitmap fields. > >But we cannot find any active users for those IPMI header files, and we >are lacking of means to perform functional tests for the changes within >this series. > >If there is active users for these header files, help for the functional >test for this patch series will be very appreciated. > >Cc: Younas Khan <[email protected]> >Cc: Michael Kinney <[email protected]> >Cc: Liming Gao <[email protected]> >Cc: Jiewen Yao <[email protected]> > >Hao Wu (2): > MdePkg/IndustryStandard/Ipmi: Update IPMI header files > MdePkg/IndustryStandard/Ipmi: Use union for bitmap fields > > MdePkg/Include/IndustryStandard/Ipmi.h | 34 +- > MdePkg/Include/IndustryStandard/IpmiFruInformationStorage.h | 92 +++ > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 546 >++++++++++++++++-- > MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 327 >++++++++--- > MdePkg/Include/IndustryStandard/IpmiNetFnStorage.h | 579 >+++++++++++++------ > MdePkg/Include/IndustryStandard/IpmiNetFnTransport.h | 603 >+++++++++++++++----- > 6 files changed, 1734 insertions(+), 447 deletions(-) > create mode 100644 >MdePkg/Include/IndustryStandard/IpmiFruInformationStorage.h > >-- >2.12.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >[email protected] >https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
