Reviewed-by: [email protected] > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, July 10, 2018 6:24 PM > To: [email protected] > Cc: Zeng, Star <[email protected]>; Kinney, Michael D > <[email protected]>; Yao, Jiewen <[email protected]>; Shao, > Ming <[email protected]> > Subject: [PATCH] MdeModulePkg CapsuleApp: Fix NestedCapsuleHeader->Flags > assigned wrong > > (FwType == ESRT_FW_TYPE_DEVICEFIRMWARE) ? system : device > should be > (FwType == ESRT_FW_TYPE_SYSTEMFIRMWARE) ? system : device > > Cc: Michael D Kinney <[email protected]> > Cc: Jiewen Yao <[email protected]> > Cc: Ming Shao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng <[email protected]> > --- > MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > index e1e48befc2de..3a1a0a1cb2e6 100644 > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c > @@ -431,7 +431,7 @@ CreateNestedFmp ( > ZeroMem(NestedCapsuleHeader, NESTED_CAPSULE_HEADER_SIZE); > CopyGuid(&NestedCapsuleHeader->CapsuleGuid, ImageTypeId); > NestedCapsuleHeader->HeaderSize = NESTED_CAPSULE_HEADER_SIZE; > - NestedCapsuleHeader->Flags = (FwType == > ESRT_FW_TYPE_DEVICEFIRMWARE) ? SYSTEM_FIRMWARE_FLAG : > DEVICE_FIRMWARE_FLAG; > + NestedCapsuleHeader->Flags = (FwType == > ESRT_FW_TYPE_SYSTEMFIRMWARE) ? SYSTEM_FIRMWARE_FLAG : > DEVICE_FIRMWARE_FLAG; > NestedCapsuleHeader->CapsuleImageSize = (UINT32)FullCapsuleBufferSize; > > CopyMem((UINT8 *)NestedCapsuleHeader + > NestedCapsuleHeader->HeaderSize, CapsuleBuffer, FileSize); > -- > 2.7.0.windows.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
