> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, July 11, 2018 5:16 AM > To: rba...@gmail.com; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Vladimir Olovyannikov > <vladimir.olovyanni...@broadcom.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Gao, Liming <liming....@intel.com>; Carsey, > Jaben <jaben.car...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > Kinney, Michael D <michael.d.kin...@intel.com>; Zhang, Chao B > <chao.b.zh...@intel.com> > Subject: Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from > eMMC/SD/USB > Importance: High > > On 07/11/18 14:05, Laszlo Ersek wrote: > > > - The OpenFileByDevicePath() function is duplicated in the following > > modules: "NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c", and > > "MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c". > With the > > implication that the alignment issue you found affects all three drivers! > > Note that I've mutually diffed the three function definitions between > each other (with "diff -b"), and there are only whitespace and comment > wrapping differences. > > So, again, this function looks like a prime suspect for UefiLib. > > I do see the strange reference at the end ("undefined SHELL_FILE_HANDLE > format"); I think that's simply stale, and should be removed.
Looks like the stale reference may be from origination as derived from ShellOpenFileByDevicePath. I agree this should be moved to a lib. Any way we could merge the shell's only slightly different version also into the mix? -Jaben > > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
