Sure. I will add the comments before commit it. Thanks, Dandan
-----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, July 19, 2018 8:04 PM To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com> Subject: Re: [edk2] [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure Hi Dandan, On 07/19/18 06:50, Dandan Bi wrote: > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c > b/UefiCpuPkg/Library/MpInitLib/Microcode.c > index efda143e67..9726172fbd 100644 > --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c > +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c > @@ -61,10 +61,12 @@ MicrocodeDetect ( > VOID *MicrocodeData; > MSR_IA32_PLATFORM_ID_REGISTER PlatformIdMsr; > UINT32 ProcessorFlags; > UINT32 ThreadId; > > + ProcessorFlags = 0; > + > if (CpuMpData->MicrocodePatchRegionSize == 0) { > // > // There is no microcode patches > // > return; > can you please add the comment from https://bugzilla.tianocore.org/show_bug.cgi?id=607 namely: // // set ProcessorFlags to suppress incorrect compiler/analyzer warnings // ProcessorFlags = 0; Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
