On 07/18/18 16:02, Ard Biesheuvel wrote: > On 18 July 2018 at 21:52, Laszlo Ersek <[email protected]> wrote: >> None of the source files referenced by "AcpiPlatformDxe.inf" #include >> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared >> therein, so drop DxeServicesLib from [LibraryClasses]. >> >> "AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI >> tables built into the firmware image from under "OvmfPkg/AcpiTables/", in >> case dynamically generated ACPI tables are not available from Xen or QEMU. >> For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for >> that in [Protocols]. >> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: Jordan Justen <[email protected]> >> Cc: Steven Shi <[email protected]> >> Reported-by: Steven Shi <[email protected]> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek <[email protected]> > > Reviewed-by: Ard Biesheuvel <[email protected]>
Thank you, commit a3fffb4f5e15. Laszlo > >> --- >> >> Notes: >> Repo: https://github.com/lersek/edk2.git >> Branch: acpiplatform_redundant_tiano_1014 >> >> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> index edc192e03d73..8440e7b343d8 100644 >> --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> @@ -46,7 +46,6 @@ [Packages] >> >> [LibraryClasses] >> UefiLib >> - DxeServicesLib >> PcdLib >> BaseMemoryLib >> DebugLib >> @@ -62,6 +61,7 @@ [LibraryClasses] >> >> [Protocols] >> gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED >> + gEfiFirmwareVolume2ProtocolGuid # PROTOCOL >> SOMETIMES_CONSUMED >> gEfiPciIoProtocolGuid # PROTOCOL >> SOMETIMES_CONSUMED >> >> [Guids] >> -- >> 2.14.1.3.gb7cf6e02401b >> > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
