Hi Anthony, (I'm seeing your v1 and v2 postings at the same time now:)
On 07/19/18 17:52, Anthony PERARD wrote: > On Debian Jessie, this fail to build with: > > /build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function > 'MicrocodeDetect': > /build/UefiCpuPkg/Library/MpInitLib/Microcode.c:248:37: error: > 'ProcessorFlags' may be used uninitialized in this function > [-Werror=maybe-uninitialized] > CpuMpData->ProcessorFlags = ProcessorFlags; > ^ > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD <[email protected]> > --- > > Notes: > v2: > Fix coding style. > > UefiCpuPkg/Library/MpInitLib/Microcode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c > b/UefiCpuPkg/Library/MpInitLib/Microcode.c > index efda143e67..cea1d34c0a 100644 > --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c > +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c > @@ -87,6 +87,7 @@ MicrocodeDetect ( > } > > ExtendedTableLength = 0; > + ProcessorFlags = 0; > // > // Here data of CPUID leafs have not been collected into context buffer, so > // GetProcessorCpuid() cannot be used here to retrieve CPUID data. > a patch for fixing this issue is on its way to being committed (Dandan posted it just ~10 hours before your v1). Please see the thread [edk2] [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure [email protected]">http://mid.mail-archive.com/[email protected] I think when Liming commented on your v1, he was unaware of Dandan's patch. And, I'm seeing your v1+v2 just now, at the same time. Sorry about the inconvenience! Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
