Hi Mark, > -----Original Message----- > From: Mark Kettenis <[email protected]> > Sent: Monday, July 23, 2018 5:04 AM > To: [email protected] > Cc: Chris Co <[email protected]> > Subject: Re: [edk2] [PATCH edk2-platforms 3/4] Platform/SolidRun: Add > Hummingboard ACPI tables > > Hi Chris, > > I noticed that in the DSDT for this platform, the _DSD for some devices uses > the Device Porperties UUID. Existing uses of this UUID on ARM platforms > within the edk2 use device properties aligned with the DeviceTree > specification > (https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww > .devicetree.org%2F&data=02%7C01%7CChristopher.Co%40microsoft.co > m%7C99f29cc6aea24ed8683908d5f0946b33%7C72f988bf86f141af91ab2d7cd0 > 11db47%7C1%7C0%7C636679442587755527&sdata=77ZJN%2F%2B0aeoj > so4KgyxwyvtEjlsF1uTMSCkCVPai5s0%3D&reserved=0). The device > properties in this patch clearly are not, even though existing bindings for > the > i.MX6 hardware you're targetting exist. > > I also noted that the "RegisterBasePA" property duplicates information > provided by _CRS, which is something that the Device Properties UUID > specification explicitly forbids.
Thank you for the feedback! We use _DSD methods in two locations: 1. SDHC - We can remove this _DSD. It is an artifact from initial development and is no longer needed. I will remove it in the next version of this patch. 2. Rhproxy - This is a Windows-specific software device to expose I/O to user applications. We have documented our required format for this _DSD here - https://docs.microsoft.com/en-us/windows/uwp/devices-sensors/enable-usermode-access I don't expect any other operating systems to use this rhproxy device. Thanks, Chris > > Cheers, > > Mark _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
