Laszlo: Thanks. I don't plan to change file attribute. I will correct the patch and send it again.
Thanks Liming >-----Original Message----- >From: Laszlo Ersek [mailto:[email protected]] >Sent: Monday, July 23, 2018 10:22 PM >To: Gao, Liming <[email protected]>; [email protected]; Guo, >Dongao <[email protected]> >Subject: Re: [edk2] [Patch] OvmfPkg: Correct library class name in INF and DSC > >Hi, > >On 07/23/18 06:34, Liming Gao wrote: >> From: Dongao Guo <[email protected]> >> >> ResourcePublicationLib class name is ResourcePublicationLib. >> INF and DSC files are updated to use the correct one. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Liming Gao <[email protected]> >> Signed-off-by: Dongao Guo <[email protected]> >> --- >> OvmfPkg/OvmfPkgIa32.dsc | 2 +- >> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- >> OvmfPkg/OvmfPkgX64.dsc | 2 +- >> OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> mode change 100644 => 100755 OvmfPkg/OvmfPkgIa32.dsc >> mode change 100644 => 100755 OvmfPkg/OvmfPkgX64.dsc >> mode change 100644 => 100755 OvmfPkg/PlatformPei/PlatformPei.inf >> >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> old mode 100644 >> new mode 100755 >> index 7ddda89..a28b511 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -268,7 +268,7 @@ >> >DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort >.inf >> !endif >> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf >> - >PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiRe >sourcePublicationLib.inf >> + >ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResou >rcePublicationLib.inf >> >ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExt >ractGuidedSectionLib.inf >> !ifdef $(SOURCE_DEBUG_ENABLE) >> >DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAg >entLib.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index 3481cdc..115d0c0 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -273,7 +273,7 @@ >> >DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort >.inf >> !endif >> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf >> - >PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiRe >sourcePublicationLib.inf >> + >ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResou >rcePublicationLib.inf >> >ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExt >ractGuidedSectionLib.inf >> !ifdef $(SOURCE_DEBUG_ENABLE) >> >DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAg >entLib.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> old mode 100644 >> new mode 100755 >> index 8b0895b..362eb78 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -273,7 +273,7 @@ >> >DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort >.inf >> !endif >> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf >> - >PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiRe >sourcePublicationLib.inf >> + >ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResou >rcePublicationLib.inf >> >ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExt >ractGuidedSectionLib.inf >> !ifdef $(SOURCE_DEBUG_ENABLE) >> >DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAg >entLib.inf >> diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf >b/OvmfPkg/PlatformPei/PlatformPei.inf >> old mode 100644 >> new mode 100755 >> index 0f347f8..9c5ad99 >> --- a/OvmfPkg/PlatformPei/PlatformPei.inf >> +++ b/OvmfPkg/PlatformPei/PlatformPei.inf >> @@ -58,7 +58,7 @@ >> HobLib >> IoLib >> PciLib >> - PeiResourcePublicationLib >> + ResourcePublicationLib >> PeiServicesLib >> PeiServicesTablePointerLib >> PeimEntryPoint >> > >thank you both for the patch. If it's not too much work, I'd like to >request the following updates: > >- Please put "ResourcePublicationLib" somewhere in the subject line. For >example: > > OvmfPkg: Correct ResourcePublicationLib class name in DSC / INF files > >- Please do not change the file mode bits of the DSC files from 100644 >to 100755. There's no reason for the DSC files to be executable. > >Thanks! >Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
