Note: I changed the subject as this is not about Laszlo's patch at this point.
Liming, I agree. We definitely need to balance performance and features. I didn't say we should add it; I assumed it was already there. Was there any side effect of a misnamed library class? Could a module have used the library with the wrong name? What if there was a library with correct name also included? -Jaben > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, July 24, 2018 5:45 PM > To: Carsey, Jaben <[email protected]>; Laszlo Ersek > <[email protected]>; edk2-devel-01 <[email protected]> > Subject: RE: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > ResourcePublicationLib resolution > Importance: High > > Jaben: > Yes. BaseTools can generate the error message for it. But, more checker in > BaseTools parser phase will also increase the build performance. This is the > balance here. > > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > Carsey, Jaben > > Sent: Wednesday, July 25, 2018 6:25 AM > > To: Laszlo Ersek <[email protected]>; edk2-devel-01 <edk2- > [email protected]> > > Subject: Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > ResourcePublicationLib resolution > > > > Laszlo, > > > > Do you think that using the incorrect name for a library instance should > generate an error? I would have thought it would have... > > > > -Jaben > > > > > -----Original Message----- > > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > > Laszlo Ersek > > > Sent: Tuesday, July 24, 2018 6:21 AM > > > To: edk2-devel-01 <[email protected]> > > > Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > > > ResourcePublicationLib resolution > > > > > > The class name for the "PeiResourcePublicationLib" instance is just > > > "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no > > > module included in the ArmVirtPkg platforms depends on this lib class; > > > remove its resolution. > > > > > > Cc: Ard Biesheuvel <[email protected]> > > > Cc: Julien Grall <[email protected]> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Laszlo Ersek <[email protected]> > > > --- > > > > > > Notes: > > > built on all six platforms: > > > > > > ArmVirtQemu-AARCH64 > > > ArmVirtQemu-ARM > > > ArmVirtQemuKernel-AARCH64 > > > ArmVirtQemuKernel-ARM > > > ArmVirtXen-AARCH64 > > > ArmVirtXen-ARM > > > > > > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > > > index 8bb54c5e6579..70a0ac4d786c 100644 > > > --- a/ArmVirtPkg/ArmVirt.dsc.inc > > > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > > > @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM] > > > > > > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > > > eLib.inf > > > > > > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN > > > ull/OemHookStatusCodeLibNull.inf > > > > > > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base > > > PeCoffGetEntryPointLib.inf > > > - > > > > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR > > > esourcePublicationLib.inf > > > > > > > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco > > > mpressLib.inf > > > > > > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > > > tractGuidedSectionLib.inf > > > > > > -- > > > 2.14.1.3.gb7cf6e02401b > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > [email protected] > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
