Star, I have verified that removing the rest of the lib mappings still builds, so those changes look good.
I have integrated these changes except the ARM/AARCH64 changes into a V6 version of the patch series. Thanks, Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, August 1, 2018 7:15 AM > To: Zeng, Star <[email protected]>; edk2- > [email protected]; Kinney, Michael D > <[email protected]> > Subject: RE: [PATCH] FmpDevicePkg: Remove useless lib > mapping in dsc > > Star, > > The ARM and AARCH64 specific lib mappings should not be > removed. > That will break the FmpDevicePkg build for ARM and > AARCH64. > > Mike > > > -----Original Message----- > > From: Zeng, Star > > Sent: Wednesday, August 1, 2018 3:30 AM > > To: [email protected] > > Cc: Zeng, Star <[email protected]>; Kinney, Michael > D > > <[email protected]> > > Subject: [PATCH] FmpDevicePkg: Remove useless lib > > mapping in dsc > > > > Cc: Michael D Kinney <[email protected]> > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > Signed-off-by: Star Zeng <[email protected]> > > > > NOTE: This patch is based on thread > > https://lists.01.org/pipermail/edk2-devel/2018- > > July/027810.html. > > > > --- > > FmpDevicePkg/FmpDevicePkg.dsc | 34 ----------------- > -- > > --------------- > > 1 file changed, 34 deletions(-) > > > > diff --git a/FmpDevicePkg/FmpDevicePkg.dsc > > b/FmpDevicePkg/FmpDevicePkg.dsc > > index 8d2436627dae..c04cb0efe86e 100644 > > --- a/FmpDevicePkg/FmpDevicePkg.dsc > > +++ b/FmpDevicePkg/FmpDevicePkg.dsc > > @@ -48,58 +48,24 @@ [Defines] > > > > [LibraryClasses] > > > > > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoin > > t/UefiDriverEntryPoint.inf > > - > > > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicatio > > nEntryPoint/UefiApplicationEntryPoint.inf > > > > > UefiBootServicesTableLib|MdePkg/Library/UefiBootService > > sTableLib/UefiBootServicesTableLib.inf > > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > > > > > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeS > > ervicesTableLib/UefiRuntimeServicesTableLib.inf > > - > > > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntim > > eLib.inf > > > > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocation > > Lib/UefiMemoryAllocationLib.inf > > > > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevi > > cePathLib.inf > > - > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > - > > > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > > > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLi > > b.inf > > - > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLi > > b/BaseSynchronizationLib.inf > > > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > > > > DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLib > > StdErr.inf > > > > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintEr > > rorLevelLib/BaseDebugPrintErrorLevelLib.inf > > - > > > PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePo > > stCodeLibPort80.inf > > > > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > - > > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeService > > sLib.inf > > - > > - > > > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeS > > ervicesTableLib/UefiRuntimeServicesTableLib.inf > > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > > - > > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevi > > cePathLib.inf > > - > > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManager > > Lib/UefiBootManagerLib.inf > > - > > > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/ > > DxeServicesTableLib.inf > > - > > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocation > > Lib/UefiMemoryAllocationLib.inf > > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > > > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > > > > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLi > > b.inf > > > > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLi > > b.inf > > > > > FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticat > > ionLibPkcs7/FmpAuthenticationLibPkcs7.inf > > - > > > > > CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpda > > tePolicyLibNull/CapsuleUpdatePolicyLibNull.inf > > > > > FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHead > > erLibV1/FmpPayloadHeaderLibV1.inf > > > > > FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpD > > eviceLibNull.inf > > - > > > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Ba > > seBmpSupportLib.inf > > - > > > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib > > .inf > > - > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCap > > suleLib.inf > > - > > -[LibraryClasses.ARM, LibraryClasses.AARCH64] > > - # > > - # It is not possible to prevent the ARM compiler > for > > generic intrinsic functions. > > - # This library provides the instrinsic functions > > generate by a given compiler. > > - # [LibraryClasses.ARM, LibraryClasses.AARCH64] and > > NULL mean link this library > > - # into all ARM and AARCH64 images. > > - # > > - > > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntri > > nsicsLib.inf > > - > > - # Add support for stack protector > > - > > > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib > > .inf > > - > > -[LibraryClasses.ARM] > > - > > > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftF > > loatLib.inf > > > > [Components] > > # > > -- > > 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
