From: Star Zeng <[email protected]> Some static tool reports "the condition in 'if' statement is constant".
This patch updates the code to use local variable to store test key digest size. It can pass the static tool's check. Cc: Michael D Kinney <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng <[email protected]> Reviewed-by: Michael D Kinney <[email protected]> --- FmpDevicePkg/FmpDxe/DetectTestKey.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/DetectTestKey.c index 6dedbdfaee..f9b983bb75 100644 --- a/FmpDevicePkg/FmpDxe/DetectTestKey.c +++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c @@ -53,12 +53,14 @@ DetectTestKey ( UINT8 *PublicKeyDataXdrEnd; VOID *HashContext; UINT8 Digest[SHA256_DIGEST_SIZE]; + UINTN TestKeyDigestSize; // // If PcdFmpDeviceTestKeySha256Digest is not exacty SHA256_DIGEST_SIZE bytes, // then skip the test key detection. // - if (PcdGetSize (PcdFmpDeviceTestKeySha256Digest) != SHA256_DIGEST_SIZE) { + TestKeyDigestSize = PcdGetSize (PcdFmpDeviceTestKeySha256Digest); + if (TestKeyDigestSize != SHA256_DIGEST_SIZE) { return; } -- 2.14.2.windows.3 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
