Shenglei, I suggest merging this patch with https://lists.01.org/pipermail/edk2-devel/2018-August/027883.html to one patch.
Thanks, Star -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of shenglei Sent: Thursday, August 2, 2018 4:45 PM To: [email protected] Cc: Dong, Eric <[email protected]>; Zeng, Star <[email protected]> Subject: [edk2] [PATCH] MdeModulePkg: Remove redundant library classes and GUIDs Some redundant library classes and GUIDs have been removed in inf, .c and .h files. https://bugzilla.tianocore.org/show_bug.cgi?id=1044 https://bugzilla.tianocore.org/show_bug.cgi?id=1045 https://bugzilla.tianocore.org/show_bug.cgi?id=1047 https://bugzilla.tianocore.org/show_bug.cgi?id=1049 https://bugzilla.tianocore.org/show_bug.cgi?id=1051 https://bugzilla.tianocore.org/show_bug.cgi?id=1052 https://bugzilla.tianocore.org/show_bug.cgi?id=1053 https://bugzilla.tianocore.org/show_bug.cgi?id=1054 https://bugzilla.tianocore.org/show_bug.cgi?id=1055 https://bugzilla.tianocore.org/show_bug.cgi?id=1056 Cc: Star Zeng <[email protected]> Cc: Eric Dong <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <[email protected]> --- MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 1 - MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 1 - .../Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 1 - .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf | 1 - MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h | 1 - MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf | 1 - .../Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 +-- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 2 -- .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf | 2 -- MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 2 -- MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2 -- MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf | 1 - MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h | 1 - MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 1 - .../Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c | 1 - .../SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf | 1 - 18 files changed, 1 insertion(+), 23 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c index 894da2f2d9..4d907242f3 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -23,7 +23,6 @@ #include <Library/PrintLib.h> #include <Library/BmpSupportLib.h> #include <Protocol/GraphicsOutput.h> -#include <Guid/GlobalVariable.h> #include <Guid/CapsuleReport.h> #include <Guid/SystemResourceTable.h> #include <Guid/FmpCapsule.h> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf index 3a67c6b909..d1b11318bb 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf @@ -40,7 +40,6 @@ MdeModulePkg/MdeModulePkg.dec [Guids] - gEfiGlobalVariableGuid ## CONSUMES ## GUID gEfiCapsuleReportGuid ## CONSUMES ## GUID gEfiFmpCapsuleGuid ## CONSUMES ## GUID gWindowsUxCapsuleGuid ## CONSUMES ## GUID diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c index 96e9977aad..a77164b436 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileIn +++ fo.c @@ -22,7 +22,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/PrintLib.h> #include <Library/UefiLib.h> #include <Library/DevicePathLib.h> -#include <Library/PeCoffGetEntryPointLib.h> #include <Library/DxeServicesLib.h> #include <Protocol/SmmCommunication.h> #include <Guid/PiSmmCommunicationRegionTable.h> diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf index 73cc052cc3..cc189fd480 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileIn +++ fo.inf @@ -42,7 +42,6 @@ UefiLib PrintLib DevicePathLib - PeCoffGetEntryPointLib DxeServicesLib [Protocols] diff --git a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf index 2fb1085c6d..c9b87eb50c 100644 --- a/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf +++ b/MdeModulePkg/Bus/I2c/I2cDxe/I2cHostDxe.inf @@ -36,7 +36,6 @@ [LibraryClasses] BaseMemoryLib DebugLib - DevicePathLib MemoryAllocationLib UefiBootServicesTableLib UefiDriverEntryPoint diff --git a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h index a2e61d6128..5a83be968f 100644 --- a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h +++ b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.h @@ -32,7 +32,6 @@ #include <Library/BaseLib.h> #include <Library/DebugLib.h> #include <Library/UefiLib.h> -#include <Library/DevicePathLib.h> #include <Library/MemoryAllocationLib.h> #include <Library/UefiBootServicesTableLib.h> #include <Library/UefiDriverEntryPoint.h> diff --git a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf index 525235635a..900fa01698 100644 --- a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf +++ b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf @@ -42,7 +42,6 @@ [LibraryClasses] BaseLib DebugLib - DevicePathLib UefiDriverEntryPoint UefiBootServicesTableLib UefiLib diff --git a/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf b/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf index f4860cdc0b..ea7207504d 100644 --- a/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -36,15 +36,14 @@ [LibraryClasses] UefiLib - DxeServicesLib PcdLib - BaseMemoryLib DebugLib UefiBootServicesTableLib UefiDriverEntryPoint [Protocols] gEfiAcpiTableProtocolGuid ## CONSUMES + gEfiFirmwareVolume2ProtocolGuid ## CONSUMES [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile ## CONSUMES diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c index 3d8e83250e..d286a48db2 100644 --- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c +++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa +++ rePerformanceDxe.c @@ -25,8 +25,6 @@ #include <Guid/Acpi.h> #include <Guid/FirmwarePerformance.h> -#include <Guid/EventGroup.h> -#include <Guid/EventLegacyBios.h> #include <Library/UefiBootServicesTableLib.h> #include <Library/UefiRuntimeServicesTableLib.h> diff --git a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf index 843cda7021..983ce41b48 100644 --- a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf +++ b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa +++ rePerformanceDxe.inf @@ -61,8 +61,6 @@ [Guids] gEfiEventExitBootServicesGuid ## CONSUMES ## Event - gEfiEventReadyToBootGuid ## CONSUMES ## Event - gEfiEventLegacyBootGuid ## SOMETIMES_CONSUMES ## Event ## SOMETIMES_CONSUMES ## HOB ## SOMETIMES_CONSUMES ## Variable:L"FirmwarePerformance" ## PRODUCES ## Variable:L"FirmwarePerformance" diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf b/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf index 4554eb485d..10a6b2c06e 100644 --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf @@ -106,8 +106,6 @@ [Guids] gEfiFileInfoGuid ## SOMETIMES_CONSUMES ## GUID - gEfiFileSystemInfoGuid ## SOMETIMES_CONSUMES ## GUID - gEfiFileSystemVolumeLabelInfoIdGuid ## SOMETIMES_CONSUMES ## GUID gEfiDebugImageInfoTableGuid ## SOMETIMES_CONSUMES ## GUID [Depex] diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h index d452b2bb2e..c8d8768abd 100644 --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h @@ -29,8 +29,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/SimpleFileSystem.h> #include <Protocol/DebuggerConfiguration.h> #include <Guid/FileInfo.h> -#include <Guid/FileSystemInfo.h> -#include <Guid/FileSystemVolumeLabelInfo.h> #include <Guid/DebugImageInfoTable.h> typedef UINTN EFI_DEBUG_STATUS; diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf index 5eb7ef924a..7f2499b33d 100644 --- a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf +++ b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf @@ -49,7 +49,6 @@ DxeServicesTableLib UefiBootServicesTableLib UefiRuntimeServicesTableLib - PrintLib [Guids] gEfiSystemResourceTableGuid ## PRODUCES ## SystemTable diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h b/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h index e0e9673c70..e6372458b9 100644 --- a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h +++ b/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.h @@ -28,7 +28,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/UefiBootServicesTableLib.h> #include <Library/DebugLib.h> #include <Library/CapsuleLib.h> -#include <Library/PrintLib.h> #include <Protocol/FirmwareManagement.h> #include <Protocol/EsrtManagement.h> diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h index 1848a92872..8529de675c 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h @@ -27,7 +27,6 @@ #include <Library/BaseLib.h> #include <Library/DebugLib.h> #include <Library/UefiLib.h> -#include <Library/IoLib.h> #include <Library/UefiDriverEntryPoint.h> #include <Library/UefiBootServicesTableLib.h> #include <Library/UefiRuntimeLib.h> diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf index da9e8e118b..2b9eabd85d 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe +++ .inf @@ -43,7 +43,6 @@ UefiRuntimeLib UefiBootServicesTableLib UefiDriverEntryPoint - IoLib UefiLib DebugLib BaseLib diff --git a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c index 3ad264b117..7d0baf8d92 100644 --- a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.c +++ b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationB +++ ufferDxe.c @@ -26,7 +26,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Library/MemoryAllocationLib.h> #include <Library/DebugLib.h> #include <Library/UefiLib.h> -#include <Library/PcdLib.h> #include <Guid/PiSmmCommunicationRegionTable.h> #define DEFAULT_COMMON_PI_SMM_COMMUNIATION_REGION_PAGES 4 diff --git a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf index 84a2318173..cc0f136c2b 100644 --- a/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferDxe.inf +++ b/MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationB +++ ufferDxe.inf @@ -50,7 +50,6 @@ MemoryAllocationLib HobLib DebugLib - PcdLib [Guids] gEdkiiPiSmmCommunicationRegionTableGuid ## PRODUCES ## SystemTable -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
