On 08/02/18 17:40, Gao, Liming wrote:
> Laszlo:
> I understand this patch set is to provide the way to append compile and
> link option for BaseTools source build.
Yes.
> If so, the extend flag name may be EXTRA_CCFLAGS
I can rename EXTRA_OPTFLAGS to EXTRA_CCFLAGS, but in that case,
internally we will have:
BUILD_OPTFLAGS = -O2 $(EXTRA_CCFLAGS)
in "header.makefile". In that case, I expect to receive a comment that
we shouldn't append a generic "CCFLAGS" variable to a more specialized
"OPTFLAGS" variable.
Obviously, I can rename "BUILD_OPTFLAGS" to "BUILD_CCFLAGS" as well --
but, in that case, I expect to receive a comment that we already have
"BUILD_CFLAGS".
The variable (more precisely, "RPM macro") that the Fedora distribution
will put into EXTRA_OPTFLAGS is also called %{optflags}. So I think
EXTRA_OPTFLAGS is an appropriate name.
If you still disagree, then can you please suggest a new name not just
for EXTRA_OPTFLAGS (-->EXTRA_CCFLAGS), but also for BUILD_OPTFLAGS?
Patch #3 explains why we need a separate BUILD_OPTFLAGS Makefile macro.
> and EXTRA_LDFLAGS.
Right, that's the currently proposed name.
> And, the extend flags are appended in the tail.
Correct.
> Besides, Pccts is the internal tool to generate VfrCompiler syntax source
> file. It is not used in build process. I am not sure why they also require
> the additional CC and LD flags.
It's a general policy thing; all native binaries should be built with
the system-wide flags. Some of those flags will let the binaries detect
some buffer overflows automatically, for example, which is helpful even
if the utility is never installed / packaged, just used as a one-off
build tool.
Thanks!
Laszlo
>
> Thanks
> Liming
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:[email protected]]
>> Sent: Thursday, July 26, 2018 8:44 AM
>> To: edk2-devel-01 <[email protected]>
>> Cc: Gao, Liming <[email protected]>; Zhu, Yonghong
>> <[email protected]>
>> Subject: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and
>> EXTRA_LDFLAGS from the caller
>>
>> Repo: https://github.com/lersek/edk2.git
>> Branch: extra_flags_rhbz1540244
>>
>> In the Fedora distribution, we'd like to pass system-wide flags related
>> to optimization and linking when the C and C++ language base tools are
>> built. This series lets the outermost "make" command push the
>> EXTRA_OPTFLAGS and EXTRA_LDFLAGS macros into the BaseTools build.
>>
>> Cc: Liming Gao <[email protected]>
>> Cc: Yonghong Zhu <[email protected]>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (6):
>> BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too
>> BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS
>> BaseTools/Source/C: split "-O2" to BUILD_OPTFLAGS
>> BaseTools/Pccts: clean up antlr and dlg makefiles
>> BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller
>> BaseTools/Source/C: take EXTRA_LDFLAGS from the caller
>>
>> BaseTools/Source/C/Makefiles/footer.makefile | 2 +-
>> BaseTools/Source/C/Makefiles/header.makefile | 16 ++++++++---
>> BaseTools/Source/C/VfrCompile/GNUmakefile | 11 +++++---
>> BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 22 ++++++++++-----
>> BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 28 +++++++++++++-------
>> 5 files changed, 56 insertions(+), 23 deletions(-)
>>
>> --
>> 2.14.1.3.gb7cf6e02401b
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
