Reviewed-by: Hao Wu <[email protected]> Best Regards, Hao Wu
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Ruiyu > Ni > Sent: Friday, August 03, 2018 11:41 AM > To: [email protected] > Cc: Wu, Hao A > Subject: [edk2] [PATCH] MdePkg/BaseLib: Add an additional check within > AsciiStriCmp > > This commit adds an addtional check in AsciiStriCmp. It > explicitly checks the end of the sting pointed by 'SecondString' to make > the code logic easier for reading and to prevent possible mis-reports by > static code checkers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <[email protected]> > Cc: Hao A Wu <[email protected]> > --- > MdePkg/Library/BaseLib/String.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/BaseLib/String.c > b/MdePkg/Library/BaseLib/String.c > index e7fe513aec..cb90774c86 100644 > --- a/MdePkg/Library/BaseLib/String.c > +++ b/MdePkg/Library/BaseLib/String.c > @@ -1262,7 +1262,7 @@ AsciiStriCmp ( > > UpperFirstString = InternalBaseLibAsciiToUpper (*FirstString); > UpperSecondString = InternalBaseLibAsciiToUpper (*SecondString); > - while ((*FirstString != '\0') && (UpperFirstString == UpperSecondString)) { > + while ((*FirstString != '\0') && (*SecondString != '\0') && > (UpperFirstString > == UpperSecondString)) { > FirstString++; > SecondString++; > UpperFirstString = InternalBaseLibAsciiToUpper (*FirstString); > -- > 2.16.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
