On 08/06/18 20:26, Jordan Justen wrote: > On 2018-08-03 08:08:13, Laszlo Ersek wrote: >> >> Should I resubmit the patch for function-scoping (and renaming) the >> global variables, or for inserting the blank linke? > > No need to resubmit. Furthermore, you can consider my suggestions as > optional. I don't feel too strongly about these ones.
I've traded the blank line which I superfluously added above "mDebugIoPortChecked", initially, for the one you pointed out as missing: > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > index 74aef2e37b42..e24cc834c2a3 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.c > @@ -16,11 +16,11 @@ > #include <Base.h> > #include "DebugLibDetect.h" > > - > // > // Set to TRUE if the debug I/O port has been checked > // > STATIC BOOLEAN mDebugIoPortChecked = FALSE; > + > // > // Set to TRUE if the debug I/O port is enabled > // I noted this on the commit message too. Pushed as commit 91a5b1365075. Thank you both! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
