Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray
> -----Original Message----- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove > redundant functions > > The functions that are never called have been removed. > They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge. > https://bugzilla.tianocore.org/show_bug.cgi?id=1062 > > Cc: Star Zeng <star.z...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei <shenglei.zh...@intel.com> > --- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 80 ------------------- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.h | 17 ---- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 41 ---------- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 21 ----- > 4 files changed, 159 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > index 48cf57a24f..f7039da992 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > @@ -1061,85 +1061,5 @@ ActiveVGADeviceOnTheRootBridge ( } > > > -/** > - Get HPC PCI address according to its device path. > - > - @param RootBridge Root bridege Io instance. > - @param RemainingDevicePath Given searching device path. > - @param PciAddress Buffer holding searched result. > - > - @retval EFI_SUCCESS PCI address was stored in PciAddress > - @retval EFI_NOT_FOUND Can not find the specific device path. > - > -**/ > -EFI_STATUS > -GetHpcPciAddressFromRootBridge ( > - IN PCI_IO_DEVICE *RootBridge, > - IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath, > - OUT UINT64 *PciAddress > - ) > -{ > - EFI_DEV_PATH_PTR Node; > - PCI_IO_DEVICE *Temp; > - EFI_DEVICE_PATH_PROTOCOL *CurrentDevicePath; > - LIST_ENTRY *CurrentLink; > - BOOLEAN MisMatch; > - > - MisMatch = FALSE; > - > - CurrentDevicePath = RemainingDevicePath; > - Node.DevPath = CurrentDevicePath; > - Temp = NULL; > - > - while (!IsDevicePathEnd (CurrentDevicePath)) { > - > - CurrentLink = RootBridge->ChildList.ForwardLink; > - Node.DevPath = CurrentDevicePath; > - > - while (CurrentLink != NULL && CurrentLink != &RootBridge->ChildList) { > - Temp = PCI_IO_DEVICE_FROM_LINK (CurrentLink); > - > - if (Node.Pci->Device == Temp->DeviceNumber && > - Node.Pci->Function == Temp->FunctionNumber) { > - RootBridge = Temp; > - break; > - } > - > - CurrentLink = CurrentLink->ForwardLink; > - } > - > - // > - // Check if we find the bridge > - // > - if (CurrentLink == &RootBridge->ChildList) { > - > - MisMatch = TRUE; > - break; > - > - } > - > - CurrentDevicePath = NextDevicePathNode (CurrentDevicePath); > - } > - > - if (MisMatch) { > - > - CurrentDevicePath = NextDevicePathNode (CurrentDevicePath); > - > - if (IsDevicePathEnd (CurrentDevicePath)) { > - *PciAddress = EFI_PCI_ADDRESS (RootBridge->BusNumber, Node.Pci- > >Device, Node.Pci->Function, 0); > - return EFI_SUCCESS; > - } > - > - return EFI_NOT_FOUND; > - } > > - if (Temp != NULL) { > - *PciAddress = EFI_PCI_ADDRESS (Temp->BusNumber, Temp- > >DeviceNumber, Temp->FunctionNumber, 0); > - } else { > - return EFI_NOT_FOUND; > - } > - > - return EFI_SUCCESS; > - > -} > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > index 1a01e72b1e..c282381f85 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > @@ -255,23 +255,6 @@ ActiveVGADeviceOnTheRootBridge ( > IN PCI_IO_DEVICE *RootBridge > ); > > -/** > - Get HPC PCI address according to its device path. > - > - @param RootBridge Root bridege Io instance. > - @param RemainingDevicePath Given searching device path. > - @param PciAddress Buffer holding searched result. > - > - @retval EFI_SUCCESS PCI address was stored in PciAddress. > - @retval EFI_NOT_FOUND Can not find the specific device path. > - > -**/ > -EFI_STATUS > -GetHpcPciAddressFromRootBridge ( > - IN PCI_IO_DEVICE *RootBridge, > - IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath, > - OUT UINT64 *PciAddress > - ); > > /** > Destroy a pci device node. > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > index 87b0b9884a..291578c63c 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > @@ -2061,47 +2061,6 @@ PciIoSetBarAttributes ( > return EFI_SUCCESS; > } > > -/** > - Program parent bridge's attribute recurrently. > - > - @param PciIoDevice Child Pci device instance > - @param Operation The operation to perform on the attributes for this > PCI controller. > - @param Attributes The mask of attributes that are used for Set, Enable, > and Disable > - operations. > - > - @retval EFI_SUCCESS The operation on the PCI controller's > attributes > was completed. > - @retval EFI_INVALID_PARAMETER One or more parameters are invalid. > - @retval EFI_UNSUPPORTED one or more of the bits set in > - Attributes are not supported by this PCI > controller or one of > - its parent bridges when Operation is Set, > Enable or Disable. > - > -**/ > -EFI_STATUS > -UpStreamBridgesAttributes ( > - IN PCI_IO_DEVICE *PciIoDevice, > - IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, > - IN UINT64 Attributes > - ) > -{ > - PCI_IO_DEVICE *Parent; > - EFI_PCI_IO_PROTOCOL *PciIo; > - > - Parent = PciIoDevice->Parent; > - > - while (Parent != NULL && IS_PCI_BRIDGE (&Parent->Pci)) { > - > - // > - // Get the PciIo Protocol > - // > - PciIo = &Parent->PciIo; > - > - PciIo->Attributes (PciIo, Operation, Attributes, NULL); > - > - Parent = Parent->Parent; > - } > - > - return EFI_SUCCESS; > -} > > /** > Test whether two Pci devices has same parent bridge. > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > index b7e38ded3f..69e7c32881 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > @@ -646,27 +646,6 @@ PciIoSetBarAttributes ( > IN OUT UINT64 *Length > ); > > -/** > - Program parent bridge's attribute recurrently. > - > - @param PciIoDevice Child Pci device instance > - @param Operation The operation to perform on the attributes for this > PCI controller. > - @param Attributes The mask of attributes that are used for Set, Enable, > and Disable > - operations. > - > - @retval EFI_SUCCESS The operation on the PCI controller's > attributes > was completed. > - @retval EFI_INVALID_PARAMETER One or more parameters are invalid. > - @retval EFI_UNSUPPORTED one or more of the bits set in > - Attributes are not supported by this PCI > controller or one of > - its parent bridges when Operation is Set, > Enable or Disable. > - > -**/ > -EFI_STATUS > -UpStreamBridgesAttributes ( > - IN PCI_IO_DEVICE *PciIoDevice, > - IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, > - IN UINT64 Attributes > - ); > > /** > Test whether two Pci devices has same parent bridge. > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
