There is a typo in commit log. 'calld' should be 'callled'. With the typo fixed, Reviewed-by: Star Zeng <star.z...@intel.com>
Thanks, Star -----Original Message----- From: Zhang, Shenglei Sent: Wednesday, August 8, 2018 4:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com> Subject: [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: Remove a redundant function The function GetStorageWidth that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng <star.z...@intel.com> Cc: Eric Dong <eric.d...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <shenglei.zh...@intel.com> --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 47 ------------------- 1 file changed, 47 deletions(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c index c778cd92f8..39e1811e69 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c @@ -3590,53 +3590,6 @@ Done: return Status; } -/** - Get Data buffer size based on data type. - - @param ValueType The input data type. - - @retval The data buffer size for the input type. -**/ -UINT16 -GetStorageWidth ( - IN UINT8 ValueType - ) -{ - UINT16 StorageWidth; - - switch (ValueType) { - case EFI_IFR_NUMERIC_SIZE_1: - case EFI_IFR_TYPE_BOOLEAN: - StorageWidth = (UINT16) sizeof (UINT8); - break; - - case EFI_IFR_NUMERIC_SIZE_2: - StorageWidth = (UINT16) sizeof (UINT16); - break; - - case EFI_IFR_NUMERIC_SIZE_4: - StorageWidth = (UINT16) sizeof (UINT32); - break; - - case EFI_IFR_NUMERIC_SIZE_8: - StorageWidth = (UINT16) sizeof (UINT64); - break; - - case EFI_IFR_TYPE_TIME: - StorageWidth = (UINT16) sizeof (EFI_IFR_TIME); - break; - - case EFI_IFR_TYPE_DATE: - StorageWidth = (UINT16) sizeof (EFI_IFR_DATE); - break; - - default: - StorageWidth = 0; - break; - } - - return StorageWidth; -} /** Update the default value in the block data which is used as bit var store. -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
