On 08/08/18 10:47, shenglei wrote: > The functions that are never called have been removed. > They are IsImageInsideSmram,FindImageRecord,SmmRemoveImageRecord, > SmmMemoryAttributesTableConsistencyCheck,DumpSmmMemoryMapEntry, > SmmMemoryMapConsistencyCheckRange,SmmMemoryMapConsistencyCheck, > DumpSmmMemoryMap,ClearGuardMapBit,SetGuardMapBit,AdjustMemoryA, > AdjustMemoryS,IsHeadGuard and IsTailGuard. > https://bugzilla.tianocore.org/show_bug.cgi?id=1062 > > Cc: Star Zeng <[email protected]> > Cc: Eric Dong <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei <[email protected]> > --- > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 166 ------------------ > .../Core/PiSmmCore/MemoryAttributesTable.c | 131 -------------- > MdeModulePkg/Core/PiSmmCore/Page.c | 121 ------------- > 3 files changed, 418 deletions(-)
Please append the following to the commit message: - FindImageRecord() is called by SmmRemoveImageRecord(); however, nothing calls SmmRemoveImageRecord(). - SmmMemoryMapConsistencyCheckRange() is called by SmmMemoryMapConsistencyCheck(); however, nothing calls SmmMemoryMapConsistencyCheck(). With these added: Reviewed-by: Laszlo Ersek <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
