Reviewed-by: [email protected]
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > shenglei > Sent: Friday, August 10, 2018 2:11 PM > To: [email protected] > Cc: Yao, Jiewen <[email protected]> > Subject: [edk2] [PATCH] SignedCapsulePkg: Remove redundant things in inf, .h > and .c files > > Two redundant library classes have been removed. > The redundant function "IsSystemFmp" has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1067 > > Cc: Jiewen Yao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei <[email protected]> > --- > .../SystemFirmwareCommonDxe.c | 27 ------------------- > .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 1 - > .../SystemFirmwareReportDxe.inf | 2 -- > 3 files changed, 30 deletions(-) > > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > index 7f7a9a1982..8e16763597 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCom > monDxe.c > @@ -343,31 +343,4 @@ InitializePrivateData ( > return EFI_SUCCESS; > } > > -/** > - Return if this FMP is a system FMP or a device FMP, based upon > FmpImageInfo. > - > - @param[in] FmpImageInfo A pointer to > EFI_FIRMWARE_IMAGE_DESCRIPTOR > - > - @retval TRUE It is a system FMP. > - @retval FALSE It is a device FMP. > -**/ > -BOOLEAN > -IsSystemFmp ( > - IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo > - ) > -{ > - GUID *Guid; > - UINTN Count; > - UINTN Index; > - > - Guid = PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid); > - Count = PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / > sizeof(GUID); > > - for (Index = 0; Index < Count; Index++, Guid++) { > - if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) { > - return TRUE; > - } > - } > - > - return FALSE; > -} > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe. > h > index 999b2b2501..cd6601e815 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe. > h > @@ -36,7 +36,6 @@ > #include <Library/UefiDriverEntryPoint.h> > #include <Library/DevicePathLib.h> > #include <Library/HobLib.h> > -#include <Library/DxeServicesLib.h> > #include <Library/DxeServicesTableLib.h> > #include <Library/PlatformFlashAccessLib.h> > #include <Library/EdkiiSystemCapsuleLib.h> > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > index cc9614ef14..b15736cf0d 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRepo > rtDxe.inf > @@ -50,9 +50,7 @@ > HobLib > UefiRuntimeServicesTableLib > UefiDriverEntryPoint > - DxeServicesLib > DxeServicesTableLib > - PrintLib > EdkiiSystemCapsuleLib > > [Pcd] > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
