Sorry, I meant 'called'. -----Original Message----- From: Zeng, Star Sent: Thursday, August 9, 2018 6:10 PM To: Zhang, Shenglei <[email protected]>; [email protected] Cc: Dong, Eric <[email protected]>; Zeng, Star <[email protected]> Subject: RE: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function
There is a typo in commit log. 'calld' should be 'callled'. With the typo fixed, Reviewed-by: Star Zeng <[email protected]> Thanks, Star -----Original Message----- From: Zhang, Shenglei Sent: Wednesday, August 8, 2018 4:47 PM To: [email protected] Cc: Zeng, Star <[email protected]>; Dong, Eric <[email protected]> Subject: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function The function DumpImageAuthentication that is never calld has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng <[email protected]> Cc: Eric Dong <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei <[email protected]> --- .../Application/CapsuleApp/CapsuleDump.c | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c index 45c3ecd050..7a3eb94362 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -106,37 +106,6 @@ DumpUxCapsule ( Print(L" OffsetY - 0x%x\n", DisplayCapsule->ImagePayload.OffsetY); } -/** - Dump FMP image authentication information. - - @param[in] Image The FMP capsule image - @param[in] ImageSize The size of the FMP capsule image in bytes. - - @return the size of FMP authentication. -**/ -UINTN -DumpImageAuthentication ( - IN VOID *Image, - IN UINTN ImageSize - ) -{ - EFI_FIRMWARE_IMAGE_AUTHENTICATION *ImageAuthentication; - - ImageAuthentication = Image; - if (CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertPkcs7Guid) || - CompareGuid(&ImageAuthentication->AuthInfo.CertType, &gEfiCertTypeRsa2048Sha256Guid)) { - Print(L"[ImageAuthentication]\n"); - Print(L" MonotonicCount - 0x%lx\n", ImageAuthentication->MonotonicCount); - Print(L"WIN_CERTIFICATE:\n"); - Print(L" dwLength - 0x%x\n", ImageAuthentication->AuthInfo.Hdr.dwLength); - Print(L" wRevision - 0x%x\n", ImageAuthentication->AuthInfo.Hdr.wRevision); - Print(L" wCertificateType - 0x%x\n", ImageAuthentication->AuthInfo.Hdr.wCertificateType); - Print(L" CertType - %g\n", &ImageAuthentication->AuthInfo.CertType); - return sizeof(ImageAuthentication->MonotonicCount) + ImageAuthentication->AuthInfo.Hdr.dwLength; - } else { - return 0; - } -} /** Dump a non-nested FMP capsule. -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
