Hi Gary, (+ Marc-André)
On 08/14/18 09:36, Gary Lin wrote: > Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those > two libraries to enable SHA384 and SHA512 support in TPM. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gary Lin <g...@suse.com> > --- > OvmfPkg/OvmfPkgIa32.dsc | 4 ++++ > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ > OvmfPkg/OvmfPkgX64.dsc | 4 ++++ > 3 files changed, 12 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index a28b511d5c2f..9f07e75050c0 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -634,6 +634,8 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > !endif > > @@ -936,5 +938,7 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > !endif > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 115d0c01ff5c..a4eaeb808c6b 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -642,6 +642,8 @@ [Components.IA32] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > !endif > > @@ -946,5 +948,7 @@ [Components.X64] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > !endif > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 362eb789c712..aa3efc5e73b9 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -641,6 +641,8 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > !endif > > @@ -944,5 +946,7 @@ [Components] > > HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf > NULL|SecurityPkg/Library/HashInstanceLibSha1/HashInstanceLibSha1.inf > > NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf > + > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf > } > !endif > this patch looks good to me, but we'll have to delay it until after the stable tag (see "EDK II Stable Tag release edk2-stable201808 and quiet period starting today"). Meanwhile, can you please repost the patch with some commit message updates (including the subject): we're not really resolving these libraries for OvmfPkg; instead we link them into Tcg2Pei and Tcg2Dxe via NULL class resolution. So I suggest the following subject: OvmfPkg: link Sha384 and Sha512 support into Tcg2Pei and Tcg2Dxe Please try to replace the "resolve those two libraries" expression in the commit message similarly. Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel