On 08/15/18 19:37, Gao, Liming wrote: > Laszlo: > The patch is good. Reviewed-by: Liming Gao <[email protected]>
Thanks! Pushed as commit range 9becf2f0759e..81502cee20ac. Laszlo > >> -----Original Message----- >> From: Laszlo Ersek [mailto:[email protected]] >> Sent: Wednesday, August 15, 2018 10:19 AM >> To: Gao, Liming <[email protected]> >> Cc: edk2-devel-01 <[email protected]> >> Subject: Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS >> and EXTRA_LDFLAGS from the caller >> >> Hi Liming, >> >> On 08/09/18 15:22, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: extra_flags_rhbz1540244_v2 >>> >>> Version 1 of this set was posted at >>> >>> [email protected]">http://mid.mail-archive.com/[email protected] >>> https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html >>> >>> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer >>> generator and the "antlr" parser generator) are not modified. Relative >>> to v1: >>> >>> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has >>> been dropped, >>> >>> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from >>> "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller" >>> and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the >>> caller". >>> >>> In other words, v2 is a proper subset of v1, so that PCCTS is left >>> alone. >>> >>> Cc: Liming Gao <[email protected]> >>> Cc: Yonghong Zhu <[email protected]> >> >> do you have any comments on patches #4 and #5? >> >> Thanks, >> Laszlo > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
