On Thu, Aug 23, 2018 at 03:35:04PM +0800, Ming wrote:
> >> +BOOLEAN
> >> +BertAddGenericErrorData (
> >> + IN EFI_ACPI_6_0_BOOT_ERROR_RECORD_TABLE_HEADER *Bert,
> >> + IN EFI_CPER_SECTION_TYPE TypeOfErrorData,
> >> + IN VOID *GenericErrorData,
> >> + IN UINT32 SizeOfGenericErrorData,
> >> + IN ERROR_SEVERITY ErrorSeverity,
> >> + IN BOOLEAN Correctable
> >> +)
> >> +{
> >> + DEBUG ((DEBUG_ERROR, "[%a]:[%dL]: \n", __FUNCTION__, __LINE__));
> >
> > Isn't this adding error data for somewhere else?
> > If so, shouldn't that be giving an error message?
> > This one amounts to "I'm logging that there was an error somewhere".
>
> I want to drop this DEBUG line. Is that ok?
Yes please.
> > This does not look like an error - should it really be of the ERROR
> > debug level? Better to move it to INFO.
> > The same applies to similar functions for the other tables.
>
> Yes, it should be INFO and I will modify similar issues in this patch.
Thanks.
> >> + DEBUG ((DEBUG_ERROR, "[%a]:[%dL]: \n", __FUNCTION__, __LINE__));
> >
> > Why this message?
>
> I think this DEBUG is useless.
> I will drop it in v4.
Yes please.
/
Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
