Laszlo, Thanks for the comment. I’ll add the info.
Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 29, 2018 9:54 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com> Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message On 08/29/18 05:21, Jian J Wang wrote: > It's reported the debug message in CpuDxe driver is quite annoying in > boot and shell, and slow down the boot process. To solve this issue, > this patch changes the DEBUG_INFO to DEBUG_VERBOSE. On a typical Intel > real platform, at least 16s boot time can be saved. > > Cc: Eric Dong <eric.d...@intel.com<mailto:eric.d...@intel.com>> > Cc: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > <jian.j.w...@intel.com<mailto:jian.j.w...@intel.com>> > --- > UefiCpuPkg/CpuDxe/CpuDxe.c | 2 +- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c > index cfd4c415ae..76661cbcd9 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.c > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c > @@ -404,7 +404,7 @@ CpuSetMemoryAttributes ( > // to avoid unnecessary computing. > // > if (mIsFlushingGCD) { > - DEBUG((DEBUG_INFO, " Flushing GCD\n")); > + DEBUG((DEBUG_VERBOSE, " Flushing GCD\n")); > return EFI_SUCCESS; > } > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index df021798c0..609df58e3a 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -528,7 +528,7 @@ SplitPage ( > ASSERT (SplitAttribute == Page4K); > if (SplitAttribute == Page4K) { > NewPageEntry = AllocatePagesFunc (1); > - DEBUG ((DEBUG_INFO, "Split - 0x%x\n", NewPageEntry)); > + DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry)); > if (NewPageEntry == NULL) { > return RETURN_OUT_OF_RESOURCES; > } > @@ -549,7 +549,7 @@ SplitPage ( > ASSERT (SplitAttribute == Page2M || SplitAttribute == Page4K); > if ((SplitAttribute == Page2M || SplitAttribute == Page4K)) { > NewPageEntry = AllocatePagesFunc (1); > - DEBUG ((DEBUG_INFO, "Split - 0x%x\n", NewPageEntry)); > + DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry)); > if (NewPageEntry == NULL) { > return RETURN_OUT_OF_RESOURCES; > } > Before you push this patch, please add a reference to https://bugzilla.tianocore.org/show_bug.cgi?id=1127 in the commit message. With that: Reviewed-by: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>> Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
